Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS dmg include link to Applications folder #624

Closed
ghost opened this issue Jun 14, 2023 · 2 comments
Closed

macOS dmg include link to Applications folder #624

ghost opened this issue Jun 14, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 14, 2023

First - have to say Media Writer is AMAZING!

This is an enhancement request. In #fedora:fedoraproject.org Matrix today, a question was asked if for the macOS dmg to include a linked folder to Applications so folks could drag and drop the app to their Applications folder?

Here's a similar example of this:
https://apple.stackexchange.com/questions/404954/how-to-create-drag-to-applications-folder-in-dmg

@ghost
Copy link
Author

ghost commented Jun 14, 2023

I think updating the dmg() function to include this might do this, I don't have Xcode installed to test, but this might work if you agree with the enhancement.

hdiutil create -srcfolder src/app/Fedora\ Media\ Writer.app -format UDCO -imagekey zlib-level=9 -scrub -volname FedoraMediaWriter-osx ../FedoraMediaWriter-osx-$VERSION.unnotarized.dmg

function dmg() {
    pushd build >/dev/null
    echo "=== Creating a disk image ==="
    # create the .dmg package - beware, it won't work while FMW is running (blocks partition mounting)
    rm -f "../*.dmg"
    STAGING_DIR="$SCRIPTDIR/staging"
    mkdir -p $STAGING_DIR
    cp -R src/app/Fedora\ Media\ Writer.app $STAGING_DIR
    ln -s /Applications $STAGING_DIR/Applications
    hdiutil create -srcfolder $STAGING_DIR -format UDCO -imagekey zlib-level=9 -scrub -volname FedoraMediaWriter-osx ../FedoraMediaWriter-osx-$VERSION.unnotarized.dmg
    rm -rf $STAGING_DIR
    popd >/dev/null
}

@grulja
Copy link
Collaborator

grulja commented Jun 14, 2023

Hi, we actually used to have it, but then I think changed/simplified it and it no longer worked. I will look into it for the next release, but I'm currently busy finishing some other work. Thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant