Moved ranking to list comprehensions and using heapq #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelikZ
added a commit
that referenced
this pull request
Sep 19, 2014
Moved ranking to list comprehensions and using heapq
FelikZ
added a commit
that referenced
this pull request
Sep 19, 2014
Added: - support for <c-d> and <c-f> modes - Added python3 compatibility Improved: - matching algorithm for all modes - better memory usage via #8 ( use heapq to find n best results )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main changes in this PR. The first is to move the loops into list comprehensions through the use of two new functions: filename_score and path_score (a minor change to make that a little tidier was that line that do not match the pattern are given a score of zero). The second major change is to use the heapq library to find the best scores so that less sorting needs to be performed.