Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the proper way to fix the issue, but for the moment it helps.
From my understanding the issue lies in the way each of the quick input menus are being called. Some like the commands menu call the Quick Input menu through the
open('filter')
as seen in the following examples:packages\core\src\browser\common-frontend-contribution.ts
packages\core\src\browser\quick-input\quick-command-frontend-contribution.ts
packages\plugin-ext-vscode\src\browser\plugin-vscode-commands-contribution.ts
As far as could tell, this is the main reason the quick input menu 'focuses' on the first option after a small amount of time. Thus, on
Enter
the first option is selected.Other files call the
showQuickPick<>()
directly and open the Quick Input menu that way. Bypassing theopen()
function somehow. One example, and probably the most important one ispackages\git\src\browser\git-quick-open-service.ts
. Specifically thecheckout()
function which is called when the menu in question is opened.What it does
This commit intends to close this issue using existing architecture.
How to test
Test is highlighted in the issue linked.
The first item should be highlighted.
Review checklist
Reminder for reviewers