Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of foundational code and document fundamental assumptions #558

Open
termi-official opened this issue Dec 14, 2022 · 1 comment

Comments

@termi-official
Copy link
Member

Ferrite-FEM/FerriteViz.jl#51 revealed another problem with something seemingly simple (i.e. generating triangle grids). With the help of #517 @koehlerson and I were able to track down issues in the build in grid generators. Some more of the recent PRs (e.g. #553 and #523) fix symptoms of something more fundamental. Technically speaking we have test coverage (in the sense of path coverage) on fundamental code, but we do not test the implementation assumptions. For example, the interpolation tests (https://github.com/Ferrite-FEM/Ferrite.jl/blob/master/test/test_interpolations.jl) cover some mathematical properties, which should be fulfilled by the implementation, but they do not cover some important implementation details. This is different from #399, which suggest a guideline for implementing new elements.

Testing the foundation will be quite tricky, because it is neither a real unit nor an integration test. Let us discuss possibilities in this thread with the goal to avoid regressions in the future (and maybe to uncover faulty assumptions between different portions of the code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant