Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More first-order CR type elements #838

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

termi-official
Copy link
Member

@termi-official termi-official commented Nov 10, 2023

These are basically useful to check if we got all assumptions right. Towards #558 .

TODOs

  • Add citations to documenter
  • Investigate what is going wrong

@termi-official termi-official changed the title More linear CR type elements More first-order CR type elements Dec 7, 2023
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (6228782) to head (64c591d).
Report is 2 commits behind head on master.

Files Patch % Lines
src/interpolations.jl 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
+ Coverage   92.94%   93.20%   +0.26%     
==========================================
  Files          38       38              
  Lines        5756     5816      +60     
==========================================
+ Hits         5350     5421      +71     
+ Misses        406      395      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@termi-official termi-official marked this pull request as ready for review July 2, 2024 17:35
@termi-official termi-official added the awaiting review PR is finished from the authors POV, waiting for feedback label Jul 2, 2024
@termi-official
Copy link
Member Author

Finally found some time to fix this and found another minor bug in the wedge integration rule. It should give us some prospective confidence in the dof management and interpolation API to also be able to support non-trivial element types. I could not find CR types for pyramids and wedges tho.

src/interpolations.jl Show resolved Hide resolved
src/interpolations.jl Show resolved Hide resolved
src/interpolations.jl Show resolved Hide resolved
src/interpolations.jl Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 2c8b751 into master Jul 2, 2024
11 checks passed
@fredrikekre fredrikekre deleted the do/more-linear-cr-type-elements branch July 2, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is finished from the authors POV, waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants