Store interpolations and quadrature rules in FEValues. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpolations are stored as abstract fields in the struct since they are never accessed in performance critical parts of the code, but it is convenient to have access too them after creating the FEValues. Closes #339.
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
- Coverage 91.15% 91.13% -0.03%
==========================================
Files 22 22
Lines 3178 3181 +3
==========================================
+ Hits 2897 2899 +2
- Misses 281 282 +1
Continue to review full report at Codecov.
|
In both CellValues and FaceValues the qr_weights field is replaced with the full quadrature rule. For FaceValues the 'dim' parameter of the quadrature rule is left abstract, but since only the weights vector is accessed in performance critical code this is not a problem in practice. Closes #361.
fredrikekre
force-pushed
the
fe/spec_vector
branch
from
692d45f
to
9321f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.