Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onboundary from examples #474

Closed
wants to merge 4 commits into from
Closed

Remove onboundary from examples #474

wants to merge 4 commits into from

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Aug 30, 2022

If removed from Neumann example, probably good to remove from examples as well? Ref #473

Edit: Also adopted an unrelated doc change from @fredrikekre's comment in #470

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #474 (c60b89e) into master (b9998a0) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   91.35%   91.32%   -0.03%     
==========================================
  Files          22       22              
  Lines        3411     3411              
==========================================
- Hits         3116     3115       -1     
- Misses        295      296       +1     
Impacted Files Coverage Δ
src/iterators.jl 95.38% <0.00%> (-1.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lijas
Copy link
Collaborator

lijas commented Aug 30, 2022

Move the face integration outside the cell loop and do:

for (cellid, faceid) in union(getfaceset(grid, "left"), getfaceset(grid, "right") )

is my prefered way :)

@KnutAM
Copy link
Member Author

KnutAM commented Aug 30, 2022

I like that better too, and it is what would be done by the BoundaryFaceIterator that is under construction!

@KnutAM
Copy link
Member Author

KnutAM commented Dec 20, 2022

Handled in #495

@KnutAM KnutAM closed this Dec 20, 2022
@KnutAM KnutAM deleted the kam/onboundary branch April 3, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants