Implement coupling support for MixedDofHandler #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
commented
Mar 28, 2023
fredrikekre
force-pushed
the
fe/mixed-coupling
branch
from
512ffa1
to
dbadef1
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 92.93% 92.97% +0.03%
==========================================
Files 30 30
Lines 4461 4481 +20
==========================================
+ Hits 4146 4166 +20
Misses 315 315
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
fredrikekre
force-pushed
the
fe/mixed-coupling
branch
2 times, most recently
from
be20d5e
to
8127128
Compare
This patch enables creating sparsity patterns with the field/component coupling specified just like for DofHandler. Also enables the Metis reordering to use coupling information when renumbering dofs in a MixedDofHandler. Closes #630.
fredrikekre
force-pushed
the
fe/mixed-coupling
branch
from
8127128
to
d668b2d
Compare
fredrikekre
added a commit
that referenced
this pull request
Mar 29, 2023
After #650, `couplings` become `Core.Box`'d due to being used in the generator for `count` so looking up the coupling in the hot loop afterwards became really slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables creating sparsity patterns with the field/component coupling specified just like for DofHandler. Also enables the Metis reordering to use coupling information when renumbering dofs in a MixedDofHandler. Closes #630.