Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell on solid-face test #926

Merged
merged 1 commit into from
May 20, 2024
Merged

Shell on solid-face test #926

merged 1 commit into from
May 20, 2024

Conversation

lijas
Copy link
Collaborator

@lijas lijas commented May 20, 2024

Test that the dofhandler distributes the dofs correctly when a shell (or beam) element is attached to the face of a solid.

Closes #899

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (821a710) to head (8b5753b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #926   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files          36       36           
  Lines        5313     5313           
=======================================
  Hits         4987     4987           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit 1fcdef1 into master May 20, 2024
9 checks passed
@fredrikekre fredrikekre deleted the shellonsolid branch May 20, 2024 13:03
@fredrikekre
Copy link
Member

Nice that no changes were required haha

@termi-official
Copy link
Member

Since I will need this in the not-so-far future, is there a good reference which explains how to couple the elements consistently? And can we add the theory to the docs?

@KnutAM
Copy link
Member

KnutAM commented May 20, 2024

Since I will need this in the not-so-far future, is there a good reference which explains how to couple the elements consistently? And can we add the theory to the docs?

I feel that I don't understand the problem/question (i.e. how it could be done inconsistently): if two elements share the same entity (face/edge/vertex), they will be coupled. Of course a write-up of how the dof-distribution works in devdocs/topic guide could be nice!

@termi-official
Copy link
Member

E.g. if you have a shell element with rotational and displacment degrees of freedom coupled to a solid element (straight line) for which you just enforce that the displacement is the same, then the shell can freely rotate on the corner of the element, so you also have to put constraints on the rotational dofs.

@KnutAM
Copy link
Member

KnutAM commented May 20, 2024

Aha, now I understand the problem, but I don't know the answer.

@koehlerson
Copy link
Member

Just don't is the answer 🙃

@KristofferC
Copy link
Collaborator

https://youtu.be/Bg2dHz2dxEM?si=H9saoVFW5OJCi5-M might be of some use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coupling shells to solid faces
6 participants