Only facetskeleton in ExclusiveTopology #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maximilian Köhler <[email protected]>
…te.jl into kam/exclusive_topology
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
+ Coverage 93.58% 93.60% +0.02%
==========================================
Files 39 39
Lines 5888 5879 -9
==========================================
- Hits 5510 5503 -7
+ Misses 378 376 -2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Dennis Ogiermann <[email protected]>
Co-authored-by: Maximilian Köhler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #988
Removes all dimension-specific skeletons, and add facet_skeleton to the topology struct. This removes methods that previously gave the wrong results, and a skeleton is then well-defined.
Against #974 untill that is merged.