Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow css-loader to resolve @imports #667

Merged
merged 1 commit into from
Nov 20, 2019
Merged

allow css-loader to resolve @imports #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dotcom-build-sass/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ export function plugin({ includePaths }: TPluginOptions = {}) {

function getCssLoaderOptions() {
return {
// Disable Webpack from resolving @import because Sass should
// have already resolved and concatenated these files.
import: false,
// Allow css-loader to resolve @import because the sass-loader
// does not successfully resolve files with a .css extension.
import: true,
// Disable Webpack from resolving url() because we do not
// currently use this functionality.
url: false
Expand Down