This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
compile the bundled code to es5 to work in IE11 #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
compile-to-es5
branch
from
435e3a5
to
ff0d2e7
Compare
notlee
reviewed
Sep 23, 2020
| @@ -41,6 +41,7 @@ module.exports.getBaseKarmaConfig = function (opts = { ignoreBower: false }) { | |||
|
|
|||
| // list of files / patterns to load in the browser | |||
| files: [ | |||
| require.resolve('@babel/polyfill/dist/polyfill.js'), | |||
There was a problem hiding this comment.
We probably shouldn't include this in our tests as then our tests won't catch when we have forgotten to define a required polyfill in origami.json -- I think those polyfills are included?
There was a problem hiding this comment.
We need to in order to get async functions working which seem to require the regenerator runtime. I couldn't get it to work any other way.
|
Closing in favour of using swc instead of babel -- #913 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.