Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prerelease workflow job #271

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix prerelease workflow job #271

merged 1 commit into from
Apr 18, 2019

Conversation

i-like-robots
Copy link
Contributor

@i-like-robots i-like-robots commented Apr 18, 2019

...by ensuring package and version variables are saved between tasks.

I'm afraid I broke this in #266

@i-like-robots i-like-robots added bug Something isn't working housekeeping Cleaning things up labels Apr 18, 2019
command: |
# https://circleci.com/docs/2.0/env-vars/#using-bash_env-to-set-environment-variables
export PRERELEASE_SEMVER='v0\.[0-9]{1,2}\.[0-9]{1,2}(-[a-z]+\.[0-9])?'
export TARGET_VERSION=$(echo $CIRCLE_TAG | grep -o -E $PRERELEASE_SEMVER);
export TARGET_MODULE=$(echo $CIRCLE_TAG | sed -E "s/-${PRERELEASE_SEMVER}//g");
echo "export TARGET_VERSION=$TARGET_VERSION" >> $BASH_ENV;
echo "export TARGET_MODULE=$TARGET_MODULE" >> $BASH_ENV;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important bit!

Copy link
Member

@apaleslimghost apaleslimghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spot, thx for fixing

@i-like-robots i-like-robots merged commit 4a1e973 into master Apr 18, 2019
@i-like-robots i-like-robots deleted the matth/fix-prerelease branch April 18, 2019 14:07
rowanbeentje pushed a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Cleaning things up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants