Partial conversion of the top albums logic to the functional style (the biggest... #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he biggest missing part is a proper implementation of CloudAlbumDataSource::requestTopAlbums()). Removed unused classes and libraries for buses, interactors and jobs. Some additional minor changes and simplifications.
jrgonzalezg
force-pushed
the
rr-fp-refactor
branch
from
c3cdcea
to
22f1fab
Compare
jrgonzalezg
changed the title
raulraja
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...missing part is a proper implementation of CloudAlbumDataSource::requestTopAlbums()). Removed unused classes and libraries for buses, interactors and jobs. Some additional minor changes and simplifications.