This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Implemented caching for sas response if a validity period is provided… #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Currenly when using the Azure version and activating the 'chunked' option, on every chunk it calls the signature endpoint to retrieve a SAS.
But you can specify an expiry time for the SAS (
SharedAccessBlobPolicy.SharedAccessExpiryTime
) and based on this, the SAS can be cached by the browser and a new request can be sent only when it expiresFor reference this is the C# code that creates the SAS and returns the url and the validity period
What browsers and operating systems have you tested these changes on?
Chrome on Windows so far, but will test across other browsers
Have you written unit tests? If not, explain why.
Looking for a confirmation first that this is something that the maintainers will agree on including. Happy to write tests.