Skip to content

Commit

Permalink
chore: refactor to use snake_case in proto (#1396)
Browse files Browse the repository at this point in the history
* chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case

* chore: update changelog

(cherry picked from commit 59f7256)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml
  • Loading branch information
jaeseung-bae authored and mergify[bot] committed May 24, 2024
1 parent de3499f commit 9d64c30
Show file tree
Hide file tree
Showing 5 changed files with 110 additions and 66 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/fbridge) [\#1369](https://github.com/Finschia/finschia-sdk/pull/1369) Add the event of `SetBridgeStatus`
* (x/fswap) [\#1372](https://github.com/Finschia/finschia-sdk/pull/1372) support message based proposals
* (x/fswap) [\#1387](https://github.com/Finschia/finschia-sdk/pull/1387) add new Swap query to get a single swap
* (x/fswap) [\#1382](https://github.com/Finschia/finschia-sdk/pull/1382) add validation & unit tests in fswap module
* (x/fswap) [\#1382](https://github.com/Finschia/finschia-sdk/pull/1382) add validation & unit tests in fswap module
* (x/fswap) [\#1396](https://github.com/Finschia/finschia-sdk/pull/1396) refactor to use snake_case in proto

### Bug Fixes
* (x/auth) [#1281](https://github.com/Finschia/finschia-sdk/pull/1281) `ModuleAccount.Validate` now reports a nil `.BaseAccount` instead of panicking. (backport #1274)
Expand Down
55 changes: 49 additions & 6 deletions client/docs/swagger-ui/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35356,11 +35356,11 @@ paths:
type: string
format: byte
parameters:
- name: fromDenom
- name: from_denom
in: query
required: false
type: string
- name: toDenom
- name: to_denom
in: query
required: false
type: string
Expand Down Expand Up @@ -35433,11 +35433,11 @@ paths:
type: string
format: byte
parameters:
- name: fromDenom
- name: from_denom
in: query
required: false
type: string
- name: toDenom
- name: to_denom
in: query
required: false
type: string
Expand Down Expand Up @@ -35626,11 +35626,11 @@ paths:
type: string
format: byte
parameters:
- name: fromDenom
- name: from_denom
in: query
required: false
type: string
- name: toDenom
- name: to_denom
in: query
required: false
type: string
Expand Down Expand Up @@ -54267,6 +54267,49 @@ definitions:

and can't be handled, they will be ignored
description: TxBody is the body of a transaction that all signers sign over.
<<<<<<< HEAD
=======
tendermint.abci.Event:
type: object
properties:
type:
type: string
attributes:
type: array
items:
type: object
properties:
key:
type: string
format: byte
value:
type: string
format: byte
index:
type: boolean
format: boolean
description: 'EventAttribute is a single key-value pair, associated with an event.'
description: >-
Event allows application developers to attach additional information to

ResponseBeginBlock, ResponseEndBlock, ResponseCheckTx and
ResponseDeliverTx.

Later, transactions may be queried using these events.
tendermint.abci.EventAttribute:
type: object
properties:
key:
type: string
format: byte
value:
type: string
format: byte
index:
type: boolean
format: boolean
description: 'EventAttribute is a single key-value pair, associated with an event.'
>>>>>>> 59f7256ca (chore: refactor to use snake_case in proto (#1396))
cosmos.upgrade.v1beta1.ModuleVersion:
type: object
properties:
Expand Down
12 changes: 6 additions & 6 deletions docs/core/proto-docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -14727,8 +14727,8 @@ GenesisState defines the fswap module's genesis state.

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `fromDenom` | [string](#string) | | |
| `toDenom` | [string](#string) | | |
| `from_denom` | [string](#string) | | |
| `to_denom` | [string](#string) | | |



Expand Down Expand Up @@ -14758,8 +14758,8 @@ GenesisState defines the fswap module's genesis state.

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `fromDenom` | [string](#string) | | |
| `toDenom` | [string](#string) | | |
| `from_denom` | [string](#string) | | |
| `to_denom` | [string](#string) | | |



Expand Down Expand Up @@ -14821,8 +14821,8 @@ GenesisState defines the fswap module's genesis state.

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `fromDenom` | [string](#string) | | |
| `toDenom` | [string](#string) | | |
| `from_denom` | [string](#string) | | |
| `to_denom` | [string](#string) | | |



Expand Down
12 changes: 6 additions & 6 deletions proto/lbm/fswap/v1/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ service Query {
}

message QuerySwappedRequest {
string fromDenom = 1;
string toDenom = 2;
string from_denom = 1;
string to_denom = 2;
}
message QuerySwappedResponse {
cosmos.base.v1beta1.Coin from_coin_amount = 1
Expand All @@ -42,17 +42,17 @@ message QuerySwappedResponse {
}

message QueryTotalSwappableToCoinAmountRequest {
string fromDenom = 1;
string toDenom = 2;
string from_denom = 1;
string to_denom = 2;
}
message QueryTotalSwappableToCoinAmountResponse {
cosmos.base.v1beta1.Coin swappable_amount = 1
[(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/Finschia/finschia-sdk/types.Coin"];
}

message QuerySwapRequest {
string fromDenom = 1;
string toDenom = 2;
string from_denom = 1;
string to_denom = 2;
}
message QuerySwapResponse {
Swap swap = 1 [(gogoproto.nullable) = false];
Expand Down
94 changes: 47 additions & 47 deletions x/fswap/types/query.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9d64c30

Please sign in to comment.