-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rollback GetBlockWithTxs
of cosmos service.proto for compatibility with cosmos-sdk APIs
#1085
feat: rollback GetBlockWithTxs
of cosmos service.proto for compatibility with cosmos-sdk APIs
#1085
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.48.0-rcx #1085 +/- ##
===============================================
Coverage 69.56% 69.57%
===============================================
Files 642 642
Lines 67328 67392 +64
===============================================
+ Hits 46838 46885 +47
- Misses 18313 18325 +12
- Partials 2177 2182 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This api also returns Block
which lacks some information in the original one. It would be better to add comments, as #1087 did.
* rc/v0.48.0-rcx: feat: add tendermint query apis for compatibility with cosmos-sdk (Finschia#1087) # Conflicts: # CHANGELOG.md
…eta1/service.proto`
Description
related: #1084
Rollback the function not supported
cosmos.tx.v1beta1.Service/GetBlockWithTxs
api of cosmos service.proto by #891 and apply the bug fix of #982 .Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml