Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rollback GetBlockWithTxs of cosmos service.proto for compatibility with cosmos-sdk APIs #1085

Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Aug 18, 2023

Description

related: #1084

Rollback the function not supported cosmos.tx.v1beta1.Service/GetBlockWithTxs api of cosmos service.proto by #891 and apply the bug fix of #982 .

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Aug 18, 2023
@zemyblue zemyblue marked this pull request as draft August 18, 2023 00:36
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1085 (03bace2) into rc/v0.48.0-rcx (4e315d6) will increase coverage by 0.00%.
The diff coverage is 73.84%.

❗ Current head 03bace2 differs from pull request most recent head e380681. Consider uploading reports for the commit e380681 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1085   +/-   ##
===============================================
  Coverage           69.56%   69.57%           
===============================================
  Files                 642      642           
  Lines               67328    67392   +64     
===============================================
+ Hits                46838    46885   +47     
- Misses              18313    18325   +12     
- Partials             2177     2182    +5     
Files Changed Coverage Δ
x/auth/tx/service.go 72.00% <73.84%> (+0.82%) ⬆️

@zemyblue zemyblue marked this pull request as ready for review August 18, 2023 03:13
jaeseung-bae
jaeseung-bae previously approved these changes Aug 21, 2023
@zemyblue zemyblue added this to the v0.48.0 milestone Aug 21, 2023
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This api also returns Block which lacks some information in the original one. It would be better to add comments, as #1087 did.

* rc/v0.48.0-rcx:
  feat: add tendermint query apis for compatibility with cosmos-sdk (Finschia#1087)

# Conflicts:
#	CHANGELOG.md
jaeseung-bae
jaeseung-bae previously approved these changes Aug 22, 2023
@zemyblue zemyblue merged commit 3185422 into Finschia:rc/v0.48.0-rcx Aug 23, 2023
33 checks passed
@zemyblue zemyblue deleted the feat/compatibility_with_cosmos branch August 23, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants