Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible overflow in BuildUnsignedTx (backport #1303) #1307

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1303 done by [Mergify](https://mergify.com).

* fix: possible overflow

* chore: update changelog

* chore: add comment

(cherry picked from commit b1c09cf)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Mar 26, 2024

Cherry-pick of b1c09cf has failed:

On branch mergify/bp/release/v0.48.x/pr-1303
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit b1c09cf6c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/tx/factory.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (8e8a284) to head (8cd3f6b).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.48.x    #1307   +/-   ##
================================================
  Coverage            69.78%   69.78%           
================================================
  Files                  646      646           
  Lines                67526    67526           
================================================
  Hits                 47126    47126           
  Misses               18214    18214           
  Partials              2186     2186           
Files Coverage Δ
client/tx/factory.go 60.50% <100.00%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech self-assigned this Mar 29, 2024
@0Tech 0Tech added A: bug Something isn't working A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users. C:client and removed conflicts A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users. labels Mar 29, 2024
@0Tech 0Tech merged commit c5fbc74 into release/v0.48.x Mar 29, 2024
47 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1303 branch March 29, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants