test(x/wasm): add integration tests for dynamic call #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
changed the title
Codecov Report
@@ Coverage Diff @@
## dynamic_link #590 +/- ##
===============================================
Coverage ? 53.16%
===============================================
Files ? 642
Lines ? 67269
Branches ? 0
===============================================
Hits ? 35764
Misses ? 28562
Partials ? 2943 |
zemyblue
reviewed
Jul 12, 2022
x/wasm/dynamic_link_test.go
Outdated
| assert.Equal(t, len(res.Events), 3) | ||
| assert.Equal(t, "wasm", res.Events[0].Type) | ||
| assert.Equal(t, len(res.Events[0].Attributes), 6) | ||
| assertAttribute(t, "contract_address", "link10pyejy66429refv3g35g2t7am0was7yaducgya", res.Events[0].Attributes[0]) |
There was a problem hiding this comment.
Where does this address, link10pyejy66429refv3g35g2t7am0was7yaducgya, come from? And is this address always the same?
There was a problem hiding this comment.
And this address seems to be repeating. If so, how about changing to a const property?
There was a problem hiding this comment.
The contract address is always the same because the code id and the instance id are the same.
But, it is out of this test, so I will delete this assertion.
x/wasm/dynamic_link_test.go
Outdated
| assertAttribute(t, "returned_pong_with_struct", "hello world 101", res.Events[0].Attributes[2]) | ||
| assertAttribute(t, "returned_pong_with_tuple", "(hello world, 42)", res.Events[0].Attributes[3]) | ||
| assertAttribute(t, "returned_pong_with_tuple_takes_2_args", "(hello world, 42)", res.Events[0].Attributes[4]) | ||
| assertAttribute(t, "returned_contract_address", "link18vd8fpwxzck93qlwghaj6arh4p7c5n89fvcmzu", res.Events[0].Attributes[5]) |
ykoyote
pushed a commit
to ykoyote/lbm-sdk
that referenced
this pull request
Jul 15, 2022
* More keeper tests x/wasm/keeper tests are extended to test various input validation. Keeper input is validated before passing to the keeper method when used within wasmd application. We cannot ensure such validation when this keeper is used outside of wasmd application. To keep it safe, fully validate keeper methods input. hackatom.wasm is loaded into memory during initialization to avoid reading file in each test separately. Once migrated to go 1.16, embed package should be used instead. Run goimport on certain files. Some comments fixed or removed. * ensure that creator address is not nil
zemyblue
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for
Other than them, this PR includes
ErrorContainsMotivation and context
Finschia/cosmwasm#186 and Finschia/cosmwasm#191
How has this been tested?
These are integration tests themselves.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)