Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete queries generated from the removed QueryAppVersionRequest/QueryAppVersionResponse #11

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Apr 19, 2023

Description

We forgot to remove the queries generated from the removed AppVersionRequest/Response. I found this issue in #10.

Removes left over code from the deletion of port/v1/query here.

This RP is the same as cosmos#2045.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

…ueryAppVersionResponse` (cosmos#2045)

* delete unused code

* remove RegisterQueryService

* remove unused import
@ulbqb ulbqb self-assigned this Apr 19, 2023
@ulbqb ulbqb added the enhancement New feature or request label Apr 19, 2023
@ulbqb ulbqb marked this pull request as ready for review April 19, 2023 02:02
zemyblue
zemyblue previously approved these changes Apr 19, 2023
tnasu
tnasu previously approved these changes Apr 19, 2023
@ulbqb ulbqb dismissed stale reviews from tnasu and zemyblue via b87e048 April 19, 2023 04:04
@ulbqb ulbqb force-pushed the fix/remove-outdated-queries branch from b87e048 to 5f05a1d Compare April 19, 2023 04:07
@ulbqb ulbqb requested review from tnasu and zemyblue April 19, 2023 04:08
@ulbqb ulbqb merged commit 023c200 into Finschia:main Apr 19, 2023
@ulbqb ulbqb deleted the fix/remove-outdated-queries branch April 19, 2023 04:42
@ulbqb ulbqb mentioned this pull request Jul 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants