Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ordered packets in UnreceivedPackets query. #15

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented May 30, 2023

Description

This is the same as cosmos#3346. But this PR contain test fix because some tests were wrong.

closes: #14

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #15 (178570b) into main (023c200) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   79.81%   79.87%   +0.05%     
==========================================
  Files         152      152              
  Lines       11104    11135      +31     
==========================================
+ Hits         8863     8894      +31     
  Misses       1812     1812              
  Partials      429      429              
Impacted Files Coverage Δ
modules/core/04-channel/keeper/grpc_query.go 90.56% <100.00%> (+0.89%) ⬆️
modules/core/keeper/msg_server.go 58.10% <100.00%> (-0.10%) ⬇️

@ulbqb ulbqb force-pushed the jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels branch from 0d2d35b to d1ae1c4 Compare May 30, 2023 12:37
@ulbqb ulbqb self-assigned this May 31, 2023
@ulbqb ulbqb added bug Something isn't working security labels May 31, 2023
@ulbqb ulbqb marked this pull request as ready for review May 31, 2023 04:50
@ulbqb ulbqb requested review from dudong2 and Mdaiki0730 May 31, 2023 05:09
@ulbqb ulbqb requested a review from zemyblue May 31, 2023 07:20
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulbqb ulbqb merged commit 59c47ab into Finschia:main May 31, 2023
@ulbqb ulbqb deleted the jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels branch May 31, 2023 09:55
@ulbqb ulbqb mentioned this pull request Jul 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to check IBC Security Advisory Huckleberry
4 participants