forked from cosmos/ibc-go
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ordered packets in UnreceivedPackets query. #15
Merged
ulbqb
merged 5 commits into
Finschia:main
from
ulbqb:jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels
May 31, 2023
Merged
Handle ordered packets in UnreceivedPackets query. #15
ulbqb
merged 5 commits into
Finschia:main
from
ulbqb:jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 79.81% 79.87% +0.05%
==========================================
Files 152 152
Lines 11104 11135 +31
==========================================
+ Hits 8863 8894 +31
Misses 1812 1812
Partials 429 429
|
ulbqb
force-pushed
the
jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels
branch
from
May 30, 2023 12:37
0d2d35b
to
d1ae1c4
Compare
zemyblue
reviewed
May 31, 2023
zemyblue
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tkxkd0159
approved these changes
May 31, 2023
ulbqb
deleted the
jim/1532-unreceivedpackets-grpc-query-handler-only-works-for-unordered-channels
branch
May 31, 2023 09:55
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same as cosmos#3346. But this PR contain test fix because some tests were wrong.
closes: #14
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml