Add e2e ci test #21
Closed
Add e2e ci test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Aug 1, 2023
| pull_request: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
How about changing this ci to be enable to test on all branch?
e2e/scripts/fnsa-chainz
Outdated
Comment on lines
39
to
40
| killall gaiad &> /dev/null | ||
| killall akash &> /dev/null |
There was a problem hiding this comment.
I think this binaries is not used.
There was a problem hiding this comment.
but I think we need the test between gaiad and fnsad.
There was a problem hiding this comment.
How about adding tests with simd of cosmos/ibc-go in this repo and adding tests with fnsad and gaiad in Finschia/finschia repo?
There was a problem hiding this comment.
How about adding tests with simd of cosmos/ibc-go in this repo and adding tests with fnsad and gaiad in Finschia/finschia repo?
That's a good idea. 👍
There was a problem hiding this comment.
I added a test with cosmos's simd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds e2e tests.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes