Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use voting power in MedianTime #110

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix: use voting power in MedianTime #110

merged 1 commit into from
Jul 23, 2020

Conversation

egonspace
Copy link
Contributor

Closes: #XXX

Description

We are using StakingPower in MedianTime now.
We must use VotingPower instead of StakingPower.
This is not critical problem because block time is not verified in block verification for now.
But I fix it to follow the meaning of voting power.

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@egonspace egonspace requested review from zemyblue and torao July 21, 2020 06:06
@egonspace egonspace self-assigned this Jul 21, 2020
@egonspace egonspace added the C: bug Classification: Something isn't working label Jul 21, 2020
@egonspace egonspace added this to the VRF election function test milestone Jul 21, 2020
@egonspace egonspace requested a review from shiki-tak July 21, 2020 07:01
zemyblue
zemyblue approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit f8e77b8 into develop Jul 23, 2020
@egonspace egonspace mentioned this pull request Aug 2, 2020
Merged
5 tasks
@egonspace egonspace deleted the fix/mediantime branch December 10, 2020 05:03
@tnasu tnasu mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@torao torao Awaiting requested review from torao

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

Assignees

@egonspace egonspace

Labels
C: bug Classification: Something isn't working
Projects
None yet
Milestone
VRF election function test
Development

Successfully merging this pull request may close these issues.
2 participants
@egonspace @zemyblue