feat: Make voter electing staisfy finality #124

kukugi · 2020-09-29T02:06:32Z

Closes: #115

Description

Change voter election to satisfy finality.

changes

Sort voters in descending voting power/staking power.
Pick up a voter in order until total staking power of voters equal to total staking power of validators
If total voting power of voters picked up less than 1/3 of total voting power then stop electing

change and write test code to fit new election

Circle CI failed with basic plan, so create new PR to use our enterprise Circle CI plan
closed #120

For contributor use:

Wrote tests
Updated CHANGELOG_PENDING.md
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments
Re-reviewed Files changed in the Github PR explorer

egonspace · 2020-10-05T04:44:53Z

libs/rand/sampling.go

@@ -10,7 +10,7 @@ import (
 type Candidate interface {
 	Priority() uint64
 	LessThan(other Candidate) bool
-	SetWinPoint(winPoint int64)
+	SetWinPoint(winPoint float64)


SetWinPoint is not needed any more in sampling module.

egonspace · 2020-10-05T04:47:53Z

libs/rand/sampling.go

-	}
-	return
+func RandomThreshold(seed *uint64, total uint64) uint64 {
+	return randomThreshold(seed, total)


How about to remove this internal function? You can implement this in RandomThreshold function directly.

egonspace · 2020-10-05T05:01:29Z

types/voter_set.go

@@ -558,6 +559,7 @@ func (voters *VoterSet) StringIndented(indent string) string {

 type candidate struct {
 	priority uint64
+	winPoint float64


It is not used any more.
And candidate structure can be moved to validator_set.go. This structure is only used in that module.

egonspace · 2020-10-05T05:01:40Z

types/voter_set.go

-	base := math.Pow10(int(precision))
-	result := (base - 1) / base
-	return result
+func (c *candidate) SetWinPoint(winPoint float64) {


Remove this.

egonspace · 2020-10-05T05:13:27Z

types/voter_set.go

-	voterCount := tmmath.MaxInt(int(voterParams.VoterElectionThreshold), int(minVoters))
-	winners := tmrand.RandomSamplingWithoutReplacement(seed, candidates, voterCount)
+	tolerableByzantinePercent := int64(voterParams.MaxTolerableByzantinePercentage)
+	winners := electVotersNonDup(validators, seed, tolerableByzantinePercent)


It's better that electVotersNonDup returns []*Valdiator instead of []voter. Because SelectVoter does not use voter.winPoint field.

egonspace · 2020-10-05T05:16:25Z

types/voter_set.go

+}
+
+func electVotersNonDup(validators *ValidatorSet, seed uint64, tolerableByzantinePercent int64) (voters []voter) {
+	validators.updateTotalStakingPower()


This was already processed in SelectVoter

remove a calling in SelectVoter

On second thought, I don't think we need to call it here either. I think the staking power should always be updated...Did you put in the code for a special reason?

some test case failed for this reason

egonspace · 2020-10-05T05:22:35Z

types/voter_set.go

+
+func electVoter(
+	seed *uint64, candidates []*Validator, voterNum int, totalPriority int64) (
+	winnerIdx int, winner voter) {


It's better that electVoter should not know voter type. Let's use *Validator type instead of it. This function does not know about winPoint.

egonspace · 2020-10-05T05:28:05Z

types/voter_set.go

+func electVotersNonDup(validators *ValidatorSet, seed uint64, tolerableByzantinePercent int64) (voters []voter) {
+	validators.updateTotalStakingPower()
+	totalPriority := validators.totalStakingPower
+	tolerableByzantinePower := totalPriority * tolerableByzantinePercent / 100


I think we must use ceil not floor for byzantine tolerable safety.

egonspace · 2020-10-05T05:43:46Z

types/voter_set.go

+		losersPriorities -= winner.val.StakingPower
+
+		//sort voters in ascending votingPower/stakingPower
+		voters = sortVoters(voters)


Shouldn't the voter sorting be done after the voting power calculation?

egonspace · 2020-10-05T05:46:03Z

types/voter_set.go

+	temp := make([]voter, len(candidates))
+	copy(temp, candidates)
+	sort.Slice(temp, func(i, j int) bool {
+		a := temp[i].val.VotingPower / temp[i].val.StakingPower


This sorting is not valid. This function treats 1/3 and 1/4 as the same value.
And as I'm telling you in advance, there's a way to compare it only with integers without conversion to float, so use it.

egonspace · 2020-10-06T01:18:54Z

types/voter_set.go

+	temp := make([]voter, len(candidates))
+	copy(temp, candidates)
+	sort.Slice(temp, func(i, j int) bool {
+		a := new(big.Int).Mul(big.NewInt(temp[i].val.VotingPower), big.NewInt(precisionForSelection))


a/b > c/d iff a*d > b*c. (a,b,c,d > 0)
so you can write it like this

a, overflow1 := safeMul(temp[i].val.VotingPower, temp[j].val.StakingPower) b, overflow2 := safeMul(temp[j].val.VotingPower, temp[i].val.StakingPower) if !overflow1 && !overflow2 { return a > b } else { bigA := new(big.Int).Mul(big.NewInt(temp[i].val.VotingPower), temp[j].val.StakingPower) bigB := new(big.Int).Mul(big.NewInt(temp[j].val.VotingPower), temp[i].val.StakingPower) return bigA.Cmp(b) == 1 }

egonspace · 2020-10-06T02:00:29Z

types/voter_set.go

+	if totalPriority*tolerableByzantinePercent%100 > 0 {
+		tolerableByzantinePower++
+	}
+	voters := make([]voter, 0)


It's not important, but how about using []*voter type?

github-actions · 2020-10-06T02:02:13Z

types/voter_set.go

+		b, overflow2 := safeMul(temp[j].val.VotingPower, temp[i].val.StakingPower)
+		if !overflow1 && !overflow2 {
+			return a > b
+		} else {


[golangci] _{reported by reviewdog 🐶}
if block ends with a return statement, so drop this else and outdent its block (golint)

egonspace · 2020-10-06T02:07:18Z

libs/rand/sampling_test.go

@@ -28,9 +29,14 @@ func (e *Element) LessThan(other Candidate) bool {
 	return e.id < o.id
 }

-func (e *Element) SetWinPoint(winPoint int64) {
-	e.winPoint += winPoint
+func (e *Element) SetWinPoint(winPoint float64) {


We can remove this.

egonspace · 2020-10-06T02:28:24Z

state/state_test.go

@@ -334,7 +333,8 @@ func TestLoadAndSaveVoters(t *testing.T) {
 		state.NextValidators = nValSet
 	}

-	for i := int64(1); i <= int64(lastHeight); i++ {
+	//no voting power in validators[1]
+	for i := int64(2); i <= int64(lastHeight); i++ {


I think we should not fix this. Voting power of the validators should be zero. Previously, the Validator was copied in SelectVoter and used.

egonspace · 2020-10-06T02:32:57Z

types/voter_set.go

+	winPoint float64
+}
+
+func electVotersNonDup(validators *ValidatorSet, seed uint64, tolerableByzantinePercent int64) []*Validator {


There is no test case to verify this function. Various test cases should be made to verify complex code.

the test case to verify that function is exist as fixed test case for previous function. but i know that can't cover current function i'll add test case comes to mind

github-actions · 2020-10-07T01:32:14Z

types/voter_set_test.go

+	assert.True(t, !isByzantine(winners, totalPriority, 20))
+}
+
+func accumulateAndResetReward(voters []*Validator, acc []uint64) uint64 {


[golangci] _{reported by reviewdog 🐶}
func accumulateAndResetReward is unused (unused)

egonspace · 2020-10-08T04:04:16Z

types/voter_set.go

@@ -712,7 +712,7 @@ func electVotersNonDup(validators *ValidatorSet, seed uint64, tolerableByzantine
 		winnerIdx, winner := electVoter(&seed, candidates, len(voters)+zeroPriorities, losersPriorities)

 		moveWinnerToLast(candidates, winnerIdx)
-		voters = append(voters, voter{
+		voters = append(voters, &voter{


I think it would be better to copy the individual winner voter in here and append it to the voters instead of copying the ValidatorSet as a whole in voter_set:566. val: winner.Copy()
This is more efficient because it can prevent unnecessary slice allocation, and only copy elected voters.

kukugi · 2020-10-08T04:20:33Z

rebased on #125

egonspace · 2020-10-08T06:13:31Z

types/voter_set.go

@@ -563,7 +563,7 @@ func SelectVoter(validators *ValidatorSet, proofHash []byte, voterParams *VoterP
 	}
 	seed := hashToSeed(proofHash)
 	tolerableByzantinePercent := int64(voterParams.MaxTolerableByzantinePercentage)
-	voters := electVotersNonDup(validators, seed, tolerableByzantinePercent)
+	voters := electVotersNonDup(validators.Copy(), seed, tolerableByzantinePercent)


We don't need to copy() any more by 716 line.

egonspace

LGTM

torao

LGTM

@shahankhatch

* mempool: rework lock discipline to mitigate callback deadlocks (backport #9030) (#9033) (manual cherry-pick of commit 22ed610083cb8275a954406296832149c4cc1dcd) Co-authored-by: M. J. Fromberger <[email protected]> * cli: add command to manually reindex tx and block events (backport: #6676) (#9034) Co-authored-by: Marko <[email protected]> * backport: Fix unsafe-reset-all for working with default home (#9103) (#9113) Co-authored-by: Callum Waters <[email protected]> * config: p2p.external-address (backport #9107) (#9153) Co-authored-by: Callum Waters <[email protected]> * (fixup) Change to OCHOME and improve tests * Backport of sam/abci-responses (#9090) (#9159) *backport of sam/abci-responses Co-authored-by: samricotta <[email protected]> Co-authored-by: William Banfield <[email protected]> * Small update to toml.go for abci-responses (#9232) * update to toml Co-authored-by: samricotta <[email protected]> * update default (#9235) Co-authored-by: samricotta <[email protected]> * Update to ABCILastResponseskey (#9253) * update last responses key Co-authored-by: samricotta <[email protected]> * cli: Enable reindex-event cmd (#9268) I noticed today that this wasn't enabled. Signed-off-by: Thane Thomson <[email protected]> Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]> * spec: migrate v0.7.1. into v0.34 (#9262) * Initial commit * Add three timeouts and align pseudocode better with existing algorithm * Align protocol with Tendermint code and add find valid value mechanism * Prepare to Nuke Develop (#47) * state -> step * vote -> v * New version of the algorithm and the proof * New version of the algorithm and the proofs * Added algorithm description * Add algorithm description * Add introduction * Add conclusion * Add conclusion file * fix warnings (caption was defined twice) - only the latter is used anyways (centers captions) - this makes it possible to autom. building the paper * Update grammar * s/state_p/step_p * Address Ismail's comments * intro: language fixes * definitions: language fixes * consensus: various fixes * proof: some fixes * try to improve reviewability * \eq -> = * textwrap to 79 * various minor fixes * proof: fix itemization * proof: more minor fixes * proof: timeouts are functions * proof: fixes to lemma6 * Intro changes and improve title page * Add Marko and Ming to acks * add readme * Format algorithm correctly Clarify condition semantic and timeouts Improve descriptions * patform -> platform * Ensure that rules are mutually exclusive - various clarifications and small improvements * Release v0.6 * small nits for smoother readability * This PR is to create signed commits to be able to merge (#50) Signed-off-by: Marko Baricevic <[email protected]> * Add consesnus and blockchain specs, (#52) - Open questions - Do we want to split lite client work from consesnsus - From the blockchain spec, is encoding nessecary in the spec Signed-off-by: Marko Baricevic <[email protected]> * Add ABCI SPEC (#51) - move the abci spec from tendermint to spec repo Signed-off-by: Marko Baricevic <[email protected]> * spec/consensus/signing: add more details about nil and amnesia (#54) - Add more details about nil votes and about amnesia attacks Signed-off-by: Marko Baricevic <[email protected]> * Add Section for P2P (#53) * Add Section for P2P - moved over the section on p2p Signed-off-by: Marko Baricevic <[email protected]> * add some more files Signed-off-by: Marko Baricevic <[email protected]> * Fix model section * Add non-recursive specification of Bisection algorithm - Fix timing issues by introducing Delta parameter * spec: update spec with tendermint updates (#62) * spec: update spec with tendermint updates - this in preperation of deleting the spec folder in docs in tendermint/tendermint Signed-off-by: Marko Baricevic <[email protected]> * spec: added in reactors & p2p Signed-off-by: Marko Baricevic <[email protected]> * spec: update readme in spec to comply with docs site Signed-off-by: Marko Baricevic <[email protected]> * docs: addded more changes from tednermint/tendermint Signed-off-by: Marko Baricevic <[email protected]> * reflect breaking changes made to Commit (#63) * reflect breaking changes made to Commit PR: tendermint/tendermint#4146 Issue: tendermint/tendermint#1648 * types: rename Commit#Precommits to Signatures * update BlockIDFlagAbsent comment * remove iota * Clean up error conditions and simplify pseudocode * Apply suggestions from code review Co-Authored-By: Anca Zamfir <[email protected]> * Add spec doc about unconditional_peer, persistent_peers_max_dial of ADR-050 (#68) * Add spec doc about unconditional_peer_ids, persistent_peers_max_dial_period of ADR-050 * Add indefinitely dialing condition * Add sr25519 amino documentation (#67) * sr25519 amino * Update spec/blockchain/encoding.md Co-Authored-By: Marko <[email protected]> * some suggestions for pseuodocode changes * Improved error handling * Add explanation on difference between trusted models * Address reviewer's comments * Addressing reviewer's comments * Separating algorithm from proofs * Intermediate commit (aligning spec with the code) * Removing Store from API and providing end-to-end timing guarantees * Address reviewer comment's. Intermediate commit * light client dir and readmes * titles * add redirects * add diagram * detection TODO * fix image * update readme * Aligh the correctness arguments with the pseudocode changes * lite->light * Fix link in readme ./light -> ./light-client * p2p: Merlin based malleability fixes (#72) * Update the secret connection spec with the use of merlin to eliminte handshake malleability * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <[email protected]> * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <[email protected]> * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <[email protected]> Co-authored-by: Anton Kaliaev <[email protected]> * docs: update specs to remove cmn (#77) - cmn was remvoed in favor of sub pkgs. cmn.kvpair is now kv.pair Signed-off-by: Marko Baricevic <[email protected]> * evidence: Add time to evidence params (#69) * evidence: Add time to evidence params - this pr is grouped together with tendermint/tendermint#4254, once that PR is merged then this one can be as well. Signed-off-by: Marko Baricevic <[email protected]> * remove note Signed-off-by: Marko Baricevic <[email protected]> * Apply suggestions from code review Co-Authored-By: Anton Kaliaev <[email protected]> Co-authored-by: Anton Kaliaev <[email protected]> * update link to the pex reactor * add markdown link checker * changed tab spacing * removed folder-path flag * first attempt at fixing all links * second attempt at fixing all links * codeowners: add code owners (#82) * codeowners: add code owners - added some codeowners please comment if youd like to be added as well. Signed-off-by: Marko Baricevic <[email protected]> * remove comment of repo maintainers * remove .idea dir (#83) Signed-off-by: Marko Baricevic <[email protected]> * RFC-001: configurable block retention (#84) * Added RFC for truncated block history coordination * Clarified minimum block retention * Added hard checks on block retention and snapshot interval, and made some minor tweaks * Genesis parameters are immutable * Use local config for snapshot interval * Reordered parameter descriptions * Clarified local config option for snapshot-interval * rewrite for ABCI commit response * Renamed RFC * add block retention diagram * Removed retain_blocks table * fix image numbers * resolved open questions * image quality * accept RFC-001 (#86) * abci: add basic description of ABCI Commit.ResponseHeight (#85) Documentation for block pruning, once it's merged: tendermint/tendermint#4588. Minimum documentation, for now - we probably shouldn't encourage using this feature too much until we release state sync. * abci: add MaxAgeNumBlocks/MaxAgeDuration to EvidenceParams (#87) * abci: update MaxAgeNumBlocks & MaxAgeDuration docs (#88) * document state sync ABCI interface and P2P protocol (#90) The corresponding Tendermint PRs are tendermint/tendermint#4704 and tendermint/tendermint#4705. * Revert "document state sync ABCI interface and P2P protocol (#90)" (#92) This reverts commit 9842b4b0fb703e609ad233af9683adc773bc95ef. * blockchain: change validator set sorting method (#91) * abci: specify sorting of RequestInitChain.Validators * blockchain: change validator sorting method Refs tendermint/tendermint#2478 * reactors/pex: specify hash function (#94) https://github.com/tendermint/tendermint/pull/4810/files * document state sync ABCI interface and P2P protocol (#93) * Revert "Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)" This reverts commit 90797cef90da762db7f7a14ce834c745140f7bcd. * update with new enum case * fix links Co-authored-by: Erik Grinaker <[email protected]> * Update evidence params with MaxNum (#95) evidence params now includes maxNum which is the maximum number of evidence that can be committed on a single block * reactors/pex: masked IP is used as group key (#96) * spec: add ProofTrialPeriod to EvidenceParam (#99) * spec: modify Header.LastResultsHash (#97) Refs: tendermint/tendermint#1007 PR: tendermint/tendermint#4845 * spec: link to abci server implementations (#100) * spec: update evidence in blockchain.md (#108) now evidence reflects the actual evidence present in the tendermint repo * abci: add AppVersion to ConsensusParams (#106) * abci: tweak node sync estimate (#115) * spec/abci: expand on Validator#Address (#118) Refs tendermint/tendermint#3732 * blockchain: rename to core (#123) * blockchain: remove duplicate evidence sections (#124) * spec/consensus: canonical vs subjective commit Refs tendermint/tendermint#2769 * Apply suggestions from code review Co-authored-by: Igor Konnov <[email protected]> * update spec with the removal of phantom validator evidence (#126) * bring blockchain back * add correct links * spec: revert event hashing (#132) * Evidence time is sourced from block time (#138) * RFC-002: non-zero genesis (#119) * abci: add ResponseInitChain.app_hash (#140) * update hashing of empty inputs, and initial block LastResultsHash (#141) * update evidence verification (#139) * accept RFC-002 (#142) * add description of arbitrary initial height (#135) * update ResponseInitChain.app_hash description (#143) * remove unused directories and update README (#145) This change removes unused directories (`papers` and `research`) and updates the README to reflect our strategy for merging the informalsystems/tendermint-rs specs into this repository. Partially addresses #121. * ci: add markdown linter (#146) * ci: add dependabot config (#148) * build(deps): bump gaurav-nelson/github-action-markdown-link-check from 0.6.0 to 1.0.7 (#149) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 0.6.0 to 1.0.7. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: add sections to abci (#150) * spec: update abci events (#151) * spec: extract light-client to its own directory (#152) Co-authored-by: Callum Waters <[email protected]> * spec: remove evidences (#153) * add a stale bot (#134) * Current versions of light client specs from tendermint-rs (#158) * current versions of light client specs from tendermint-rs * markdown lint * linting * links * links * links Co-authored-by: Marko Baricevic <[email protected]> * Fastsync spec from tendermint-rs (#157) * fastsync spec from tendermint-rs * fixed broken link * fixed linting * more fixes * markdown lint * move fast_sync to rust-spec Co-authored-by: Marko Baricevic <[email protected]> * Update README.md (#160) * spec/reactors/mempool: batch txs per peer (#155) * spec/reactors/mempool: batch txs per peer Refs tendermint/tendermint#625 * update * spec: Light client attack detector (#164) * start with new detection and evidence spec * more definitions at top * sketch of functions * pre post draft * evidence proof * typo * evidence theory polished * some TODOs resolved * more TODOs * links * second to last revision before PR * links * I will read once more and then make a PR * removed peer handling definitions * secondary * ready to review * detector ready for review * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * Update rust-spec/lightclient/detection/detection.md * skip-trace * PossibleCommit explained * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <[email protected]> * comments by Zarko * renamed and changed link in README Co-authored-by: Zarko Milosevic <[email protected]> * fixed an overlooked conflict (#167) * describe valset sorting according to v0.34 requirements (#169) * evidence: update data structures (#165) * fix markdown linter (#172) * TLA+ specs from MBT revision (#173) * remove setOption (#181) * spec: protobuf changes (#156) Co-authored-by: Anton Kaliaev <[email protected]> * first check latest with secondary (#184) * Extending the blockchain specification (in the light client) to produce different ratios of faults (#183) * cleaning unused definitions * introduced the ratio of faulty processes * Update README.md (#185) * build(deps): bump gaurav-nelson/github-action-markdown-link-check from 1.0.7 to 1.0.8 (#188) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.7 to 1.0.8. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.7...e3c371c) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * spec: update light client verification to match supervisor (#171) * VDD renaming of verification spec + links fixed * latest() * backwards * added TODOs * link in old file to new name * better text * revision done. needs one more round of reading * renamed constants in 001 according to TLA+ and impl * ready for PR * forgot linting * Update rust-spec/lightclient/verification/verification_002_draft.md * Update rust-spec/lightclient/verification/verification_002_draft.md * added lightstore function needed for supervisor * added lightstore functions for supervisor * ident * Update rust-spec/lightclient/verification/verification_002_draft.md * github: issue template for proposals (#190) * Sequential Supervisor (#186) * move from tendermint-rs but needs discussion * markdown lint * TODO links replaced * links * links * links lint * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * moved peer handling definitions to supervisor * polishing * rename * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * changes to maintain StateVerified again * ready for changes in verification * start of supervisor * module name * fixed * more details * supevisor completed. Now I have to add function to verification * ready for review * tla comment * removed issues * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * intro text fixed * indentation * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * comment to entry points Co-authored-by: Marko Baricevic <[email protected]> * RFC: adopt zip 215 (#144) Co-authored-by: Robert Zaremba <[email protected]> * Core: move validation & data structures together (#176) Co-authored-by: Callum Waters <[email protected]> * docs: make blockchain not viewable (#211) * evidence: update data structures to reflect added support of abci evidence (#213) * encoding: add secp, ref zip215, tables (#212) * Detector English Spec ready (#215) Add detector English spec * add Ivy proofs (#210) * add Ivy proofs * fix docker-compose command * Light client detector spec in TLA+ and refactoring of light client verification TLA+ spec (#216) Add light client detector spec in TLA+ * abci: lastcommitinfo.round extra sentence (#221) * abci: add abci_version to requestInfo (#223) * BFT requires _less than_ 1/3 faulty validators (#228) Thanks fo spotting the imprecision in the text, @shahankhatch ! * Draft of evidence handling for discussion (#225) * start with accountability deliverable * problem statement * draft function * quite complete draft. ready to discuss with Igor * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * ready for TLA+ to take over * isolate * isolateamnesiatodos * Update isolate-attackers_001_draft.md * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <[email protected]> * The TLA+ specification of the attackers detection (#231) * the working attackers isolation spec, needs more comments * the TLA+ spec of the attackers isolation * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#233) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.11. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.8...2a60e0f) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Computing attack types (#232) Add light attack evidence handling * Update README.md (#234) * p2p: update frame size (#235) Reflect the change made in tendermint/tendermint#5805 The MTU (Maximum Transmission Unit) for Ethernet is 1500 bytes. The IP header and the TCP header take up 20 bytes each at least (unless optional header fields are used) and thus the max for (non-Jumbo frame) Ethernet is 1500 - 20 -20 = 1460 Source: https://stackoverflow.com/a/3074427/820520 * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#239) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.11...0fe4911) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * layout: add section titles (#240) * reactors: remove bcv1 (#241) * abci: rewrite to proto interface (#237) * Update supervisor_001_draft.md (#243) * spec: remove reactor section (#242) Co-authored-by: Tess Rinearson <[email protected]> * non-critical bugfix in the TLA+ spec (found by new version of apalache) (#244) * params: remove block timeiota (#248) * proto: add files (#246) Co-authored-by: Erik Grinaker <[email protected]> * proto: modify height int64 to uint64 (#253) * abci: note on concurrency (#258) Co-authored-by: Marko <[email protected]> * spec: merge rust-spec (#252) * Fix list of RFCs (#266) * readme: cleanup (#262) * modify readme * add rfc and proto * add rust=spec back to avoid breakage * lint readme * genesis: Explain fields in genesis file (#270) * describe the genesis * Update spec/core/genesis.md Co-authored-by: Dev Ojha <[email protected]> * Apply suggestions from code review Co-authored-by: Callum Waters <[email protected]> * add wording on app_state * Update spec/core/genesis.md Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Callum Waters <[email protected]> * p2p: links (#268) * fix links * fix more links * Proposer-based timestamp specification (#261) * added proposer-based timestamp spec * Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md Co-authored-by: Marko <[email protected]> * Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md * Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_001_draft.md Co-authored-by: Callum Waters <[email protected]> * fixes from PR Co-authored-by: Josef Widder <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Callum Waters <[email protected]> * abci: reorder sidebar (#282) * ABCI++ RFC (#254) * ABCI++ RFC This commit adds an RFC for ABCI++, which is a collection of three new phases of communication between the consensus engine and the application. Co-authored-by: Sunny Aggarwal <[email protected]> * Fix bugs pointed out by @liamsi * Update rfc/004-abci++.md Co-authored-by: Federico Kunze <[email protected]> * Fix markdown lints * Update rfc/004-abci++.md Co-authored-by: Ismail Khoffi <[email protected]> * Update rfc/004-abci++.md Co-authored-by: Tess Rinearson <[email protected]> * Update rfc/004-abci++.md Co-authored-by: Tess Rinearson <[email protected]> * Add information about the rename in the context section * Bold RFC * Add example for self-authenticating vote data * More exposition of the term IPC * Update pros / negatives * Fix sentence fragment * Add desc for no-ops Co-authored-by: Sunny Aggarwal <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Ismail Khoffi <[email protected]> Co-authored-by: Tess Rinearson <[email protected]> * RFC: ReverseSync - fetching historical data (#224) * core: update a few sections (#284) * p2p: update state sync messages for reverse sync (#285) * Update README.md (#286) * rpc: define spec for RPC (#276) * add rpc spec and support outline * add json * add more routes remove unneeded ones * add rest of rpc endpoints * add jsonrpc calls * add more jsonrpc calls * fix blockchain * cleanup unused links and add links to repos * Update spec/rpc/README.md Co-authored-by: Callum Waters <[email protected]> * add missing param from consensus param * Update spec/rpc/README.md Co-authored-by: Callum Waters <[email protected]> * Update spec/rpc/README.md Co-authored-by: Callum Waters <[email protected]> * fix cast and add doc to readme Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Marko Baricevic <[email protected]> * A few improvements to the Ivy proof (#288) * Avoid quantifier alternation cycle The problematic quantifier alternation cycle arose because the definition of accountability_violation was unfolded. This commit also restructures the induction proof for clarity. * add count_lines.sh * fix typo and add forgotten complete=fo in comment Co-authored-by: Giuliano <[email protected]> * Fixed a broken link (#291) * fix message type for block-sync (#298) * lint: fix lint errors (#301) * build(deps): bump actions/stale from 3 to 3.0.18 (#300) Bumps [actions/stale](https://github.com/actions/stale) from 3 to 3.0.18. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3...v3.0.18) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/stale from 3.0.18 to 3.0.19 (#302) Bumps [actions/stale](https://github.com/actions/stale) from 3.0.18 to 3.0.19. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.18...v3.0.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * rename HasVote to ReceivedVote (#289) * add a changelog to track changes (#303) * add a changelog to track changes * Update CHANGELOG.md Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Callum Waters <[email protected]> * rpc: clarify timestamps (#304) * clarify timestamps * changelog entry * Update spec/rpc/README.md Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Callum Waters <[email protected]> * rpc: add chunked genesis endpoint (#299) * rpc: add chunked genesis endpoint * fix lint * feedback * add info about error * fix lint Co-authored-by: marbar3778 <[email protected]> * update ResponseCheckTx (#306) * rpc: Add totalGasUSed to block_results response (#308) * Add C++ code generation and test scenario (#310) * add parameters to byzantine send action * make net not trusted it's not necessary since for proofs Ivy will assume that the environment does not break action preconditions * use require instead of assume it seems that assume is not checked when other isolates call! * add comment * add comment * run with random seed * make domain model extractable to C++ * substitute require for assume assumes in an action are not checked when the action is called! I.e. they place no requirement on the caller; we're just assuming that the caller is going to do the right thing. This wasn't very important here but it leade to a minor inconsistency slipping through. * make the net isolate not trusted there was no need for it * add tendermint_test.ivy contains a simple test scenario that show that the specification is no vacuuous * update comment * add comments * throw if trying to parse nset value in the repl * add comment * minor refactoring * add new pex messages (#312) * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#313) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.12 to 1.0.13. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.12...1.0.13) --- updated-dependencies: - dependency-name: gaurav-nelson/github-action-markdown-link-check dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update spec to reference currently used timestamp type (#317) * build(deps): bump actions/stale from 3.0.19 to 4 (#319) Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 4. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3.0.19...v4) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * address discrepancies between spec and implementation (#322) * update proto files for release (#318) * stale bot: ignore issues (#325) * evidence: add section explaining evidence (#324) * statesync: new messages for gossiping consensus params (#328) * rpc: update peer format in specification in NetInfo operation (#331) * Update supervisor_001_draft.md (#334) * core: text cleanup (#332) * abci: clarify what abci stands for (#336) * abci: clarify what abci stands for * link to abci type protos. * abci: clarify connection use in-process (#337) * abci: clarify connection use in-process * Update abci.md * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * invert abci explanations * lint++ * lint++ * lint++ * lint++ Co-authored-by: M. J. Fromberger <[email protected]> * proto: move proto files under the correct directory related to their package name (#344) * abci.md fixup (#339) * abci: points of clarification ahead of v0.1.0 * lint++ * typo * lint++ * double word score * grammar * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <[email protected]> * pr feedback * wip * update non-zero status code docs * fix event description * update CheckTx description Co-authored-by: M. J. Fromberger <[email protected]> * Update supervisor_001_draft.md (#333) * Update supervisor_001_draft.md If the only node in the *FullNodes* set is the primary, that was just deemed faulty, we can't find honest primary. * Update supervisor_001_draft.md * light: update initialization description (#320) * apps.md fixups (#341) * wip * wip * wip * remove comments in favor of gh comments * wip * udpates to language, should must etc * Apply suggestions from code review Co-authored-by: M. J. Fromberger <[email protected]> * remove tendermint cache description Co-authored-by: M. J. Fromberger <[email protected]> * proto: add tendermint go changes (#349) * add missed proto files * add abci changes * rename blockchain to blocksync * Update proto/tendermint/abci/types.proto Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Callum Waters <[email protected]> * fix mockery generation script (#9094) Signed-off-by: Marko Baricevic <[email protected]> Co-authored-by: Milosevic, Zarko <[email protected]> Co-authored-by: Milosevic, Zarko <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Anton Kaliaev <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: dongsamb <[email protected]> Co-authored-by: Sunny Aggarwal <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Ethan Buchman <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Ismail Khoffi <[email protected]> Co-authored-by: Zaki Manian <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Tess Rinearson <[email protected]> Co-authored-by: Alexander Simmerl <[email protected]> Co-authored-by: Igor Konnov <[email protected]> Co-authored-by: Sean Braithwaite <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josef Widder <[email protected]> Co-authored-by: Andrey Kuprianov <[email protected]> Co-authored-by: Igor Konnov <[email protected]> Co-authored-by: Sam Hart <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: Shahan Khatchadourian <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: istoilkovska <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Sam Kleinman <[email protected]> Co-authored-by: Sunny Aggarwal <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Marko Baricevic <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: Jordan Sexton <[email protected]> Co-authored-by: MengXiangJian <[email protected]> Co-authored-by: Yixin Luo <[email protected]> Co-authored-by: crypto-facs <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: William Banfield <[email protected]> Co-authored-by: Mateusz Górski <[email protected]> Co-authored-by: M. J. Fromberger <[email protected]> Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Callum Waters <[email protected]> * config: Move `discard_abci_responses` flag into its own storage section (#9275) * config: Move discard_abci_responses flag into its own storage section Signed-off-by: Thane Thomson <[email protected]> * Update config comment to highlight space saving tradeoff Signed-off-by: Thane Thomson <[email protected]> Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]> * docs: Minor recommendations prior to v0.34.21 release (#9267) * Make reindex-event cmd docs consistent with other commands Signed-off-by: Thane Thomson <[email protected]> * Add warning regarding DiscardABCIResponses to BlockResults Go API Signed-off-by: Thane Thomson <[email protected]> * Update OpenAPI spec to reflect discard_abci_responses change Signed-off-by: Thane Thomson <[email protected]> * Add release highlights to CHANGELOG_PENDING Signed-off-by: Thane Thomson <[email protected]> * Add pending changelog entry for #9033 Signed-off-by: Thane Thomson <[email protected]> * Format pending changelog entries consistently Signed-off-by: Thane Thomson <[email protected]> * Correct and simplify comment wording Signed-off-by: Thane Thomson <[email protected]> * Remove changelog entry regarding storage section Signed-off-by: Thane Thomson <[email protected]> Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Thane Thomson <[email protected]> --------- Signed-off-by: Marko Baricevic <[email protected]> Co-authored-by: M. J. Fromberger <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Callum Waters <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: William Banfield <[email protected]> Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Milosevic, Zarko <[email protected]> Co-authored-by: Milosevic, Zarko <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Anton Kaliaev <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: dongsamb <[email protected]> Co-authored-by: Sunny Aggarwal <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Ethan Buchman <[email protected]> Co-authored-by: Zarko Milosevic <[email protected]> Co-authored-by: Ismail Khoffi <[email protected]> Co-authored-by: Zaki Manian <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Tess Rinearson <[email protected]> Co-authored-by: Alexander Simmerl <[email protected]> Co-authored-by: Igor Konnov <[email protected]> Co-authored-by: Sean Braithwaite <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josef Widder <[email protected]> Co-authored-by: Andrey Kuprianov <[email protected]> Co-authored-by: Igor Konnov <[email protected]> Co-authored-by: Sam Hart <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: Shahan Khatchadourian <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: istoilkovska <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Sam Kleinman <[email protected]> Co-authored-by: Sunny Aggarwal <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Marko Baricevic <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: Jordan Sexton <[email protected]> Co-authored-by: MengXiangJian <[email protected]> Co-authored-by: Yixin Luo <[email protected]> Co-authored-by: crypto-facs <[email protected]> Co-authored-by: Giuliano <[email protected]> Co-authored-by: Mateusz Górski <[email protected]> Co-authored-by: Thane Thomson <[email protected]>

kukugi mentioned this pull request Sep 29, 2020

feat: Make voter electing staisfy finality #120

Closed

5 tasks

kukugi self-assigned this Sep 29, 2020

kukugi requested review from egonspace and torao and removed request for egonspace September 29, 2020 02:11

egonspace reviewed Oct 5, 2020

View reviewed changes

egonspace reviewed Oct 6, 2020

View reviewed changes

github-actions bot reviewed Oct 6, 2020

View reviewed changes

kukugi force-pushed the feat/voting branch from 4d77aab to e0d3185 Compare October 6, 2020 02:05

egonspace reviewed Oct 6, 2020

View reviewed changes

kukugi force-pushed the feat/voting branch from e0d3185 to ae4a469 Compare October 6, 2020 03:39

Woosang Son added 6 commits October 6, 2020 17:16

feat: add an option for selecting priv key type

bd6517e

fix: test cases

45c1ca9

fix: fmt error

76a2569

fix: golang ci error

6f5e4f7

fix: apply priv-key-type option to testnet command

61f4321

fix: bls compile problem

ca35310

github-actions bot reviewed Oct 7, 2020

View reviewed changes

Woosang Son added 2 commits October 7, 2020 17:30

fix: contract-tests failure

a5e6801

fix: modify change log pending

dcc16b7

kukugi force-pushed the feat/voting branch from 8f7954a to 2b6a590 Compare October 8, 2020 02:02

kukugi added 5 commits October 8, 2020 12:03

feat: Make voting satisfy finality

71b3931

fix: Make voter sorting working well

8c1e48e

Move sampling logic to types package

e6e911a

Change the voter that don't use winpoint to validator

b86d943

Change condition to sort voters

4161f5a

egonspace reviewed Oct 8, 2020

View reviewed changes

kukugi force-pushed the feat/voting branch from 2b6a590 to 2ec0938 Compare October 8, 2020 04:18

kukugi force-pushed the feat/voting branch from 2ec0938 to c293546 Compare October 8, 2020 04:24

fix: Fix error during test run

b1348de

kukugi force-pushed the feat/voting branch from c293546 to b1348de Compare October 8, 2020 04:48

egonspace reviewed Oct 8, 2020

View reviewed changes

egonspace approved these changes Oct 8, 2020

View reviewed changes

torao approved these changes Oct 8, 2020

View reviewed changes

kukugi merged commit 01beee1 into develop Oct 13, 2020

kukugi mentioned this pull request Oct 23, 2020

test: Write a test case to verify a new voter sampling #129

Merged

5 tasks

egonspace mentioned this pull request Oct 26, 2020

Consensus by the currently elected voter does not satisfy finality. #115

Closed

4 tasks

egonspace deleted the feat/voting branch December 10, 2020 05:03

syleeeee unassigned kukugi Jun 7, 2021

tnasu mentioned this pull request Jul 27, 2022

Swap StakingPower and VotingPower, and modify from StakingPower to VotingWeight #449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make voter electing staisfy finality #124

feat: Make voter electing staisfy finality #124

kukugi commented Sep 29, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

kukugi Oct 5, 2020

egonspace Oct 8, 2020

kukugi Oct 8, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020

egonspace Oct 5, 2020 •

edited

Loading

egonspace Oct 6, 2020 •

edited

Loading

egonspace Oct 6, 2020

github-actions bot Oct 6, 2020

egonspace Oct 6, 2020

egonspace Oct 6, 2020 •

edited

Loading

egonspace Oct 6, 2020

kukugi Oct 8, 2020

github-actions bot Oct 7, 2020

egonspace Oct 8, 2020 •

edited

Loading

kukugi commented Oct 8, 2020

egonspace Oct 8, 2020

egonspace left a comment

torao left a comment

feat: Make voter electing staisfy finality #124

feat: Make voter electing staisfy finality #124

Conversation

kukugi commented Sep 29, 2020

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egonspace Oct 5, 2020 • edited Loading

Choose a reason for hiding this comment

egonspace Oct 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egonspace Oct 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

egonspace Oct 8, 2020 • edited Loading

Choose a reason for hiding this comment

kukugi commented Oct 8, 2020

Choose a reason for hiding this comment

egonspace left a comment

Choose a reason for hiding this comment

torao left a comment

Choose a reason for hiding this comment

egonspace Oct 5, 2020 •

edited

Loading

egonspace Oct 6, 2020 •

edited

Loading

egonspace Oct 6, 2020 •

edited

Loading

egonspace Oct 8, 2020 •

edited

Loading