Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return postCheck error to abci client #507

Merged
merged 15 commits into from
Nov 25, 2022
Merged

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Nov 24, 2022

Description

This PR has following changes:

@ulbqb ulbqb changed the title fix: fix: add postCheck error to abci response Nov 24, 2022
@ulbqb ulbqb self-assigned this Nov 24, 2022
@ulbqb ulbqb changed the title fix: add postCheck error to abci response fix: return postCheck error to abci client Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #507 (953c00c) into main (15a55a2) will increase coverage by 0.09%.
The diff coverage is 67.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   65.50%   65.59%   +0.09%     
==========================================
  Files         278      279       +1     
  Lines       37966    38017      +51     
==========================================
+ Hits        24868    24938      +70     
+ Misses      11292    11277      -15     
+ Partials     1806     1802       -4     
Impacted Files Coverage Δ
consensus/replay_stubs.go 57.14% <ø> (ø)
node/node.go 60.48% <0.00%> (+0.36%) ⬆️
rpc/core/mempool.go 0.00% <0.00%> (ø)
rpc/core/types/responses.go 35.71% <ø> (ø)
mempool/clist_mempool.go 82.16% <64.00%> (-0.25%) ⬇️
mempool/mempool.go 100.00% <100.00%> (ø)
state/execution.go 67.15% <100.00%> (+0.08%) ⬆️
state/tx_filter.go 100.00% <100.00%> (ø)
types/tx.go 90.24% <0.00%> (-3.66%) ⬇️
p2p/switch.go 66.52% <0.00%> (-2.28%) ⬇️
... and 15 more

@ulbqb ulbqb marked this pull request as ready for review November 24, 2022 08:25
proto/ostracon/abci/types.proto Outdated Show resolved Hide resolved
rpc/core/mempool.go Show resolved Hide resolved
mempool/clist_mempool.go Outdated Show resolved Hide resolved
proto/ostracon/abci/types.proto Show resolved Hide resolved
mempool/clist_mempool.go Outdated Show resolved Hide resolved
@ulbqb ulbqb requested a review from tnasu November 24, 2022 13:10
mempool/clist_mempool.go Outdated Show resolved Hide resolved
@tnasu tnasu added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 25, 2022
@ulbqb ulbqb requested review from tnasu and torao November 25, 2022 04:11
mempool/clist_mempool.go Outdated Show resolved Hide resolved
@ulbqb ulbqb requested review from 0Tech and dudong2 November 25, 2022 05:51
tnasu
tnasu previously approved these changes Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants