-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return postCheck error to abci client #507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
changed the title
fix: add postCheck error to abci response
fix: return postCheck error to abci client
Nov 24, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 65.50% 65.59% +0.09%
==========================================
Files 278 279 +1
Lines 37966 38017 +51
==========================================
+ Hits 24868 24938 +70
+ Misses 11292 11277 -15
+ Partials 1806 1802 -4
|
This reverts commit 39aabac.
torao
reviewed
Nov 24, 2022
tnasu
requested changes
Nov 24, 2022
tnasu
requested changes
Nov 25, 2022
tnasu
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Nov 25, 2022
tnasu
requested changes
Nov 25, 2022
tnasu
previously approved these changes
Nov 25, 2022
tnasu
approved these changes
Nov 25, 2022
torao
approved these changes
Nov 25, 2022
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has following changes:
postCheck
in onlyresCbRecheck
(revert chore: remove mempool.postCheck (#158) #217)postCheck
error to abci client (apply mempool: return mempool errors to the abci client tendermint/tendermint#6740)