querystring: fix broken stringifyPrimitive

stringifyPrimitive has always failed to stringify numbers since its introduction in 422d3c9. This went uncaught due to encodeURIComponent's string coercion. Fixes: nodejs#1208 PR-URL: nodejs#1213 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Brian White <[email protected]>
Fishrock123 · Mar 20, 2015 · c9aec2b · c9aec2b
1 parent a89f5c2
commit c9aec2b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -147,8 +147,10 @@ QueryString.escape = function(str) {
 };
 
 var stringifyPrimitive = function(v) {
-  if (typeof v === 'string' || (typeof v === 'number' && isFinite(v)))
+  if (typeof v === 'string')
     return v;
+  if (typeof v === 'number' && isFinite(v))
+    return '' + v;
   if (typeof v === 'boolean')
     return v ? 'true' : 'false';
   return '';