-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Scheduled segment overrides #4805
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Uffizzi Ephemeral Environment
|
@kyle-ssg I'm a little confused by this one: Firstly, I don't understand how the following can be true since scheduled updates rely on change requests under the hood, and we don't support change requests for segments in non-versioned environments.
Secondly, when I tried to test it, the first thing that happened was that I was just redirected to the billing page directly which confused me. I think it's because scheduled flags aren't available for non-paid plans, but I'm unsure why we're not using the pattern we have elsewhere that shows a banner that it's only available in another plan. Then, when I tested it in an organisation that is using the enterprise plan, using a non-versioned environment, it just appears to immediately apply the change, I don't see the scheduling modal pop up. |
# Conflicts: # frontend/web/components/base/forms/Button.tsx
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Adds the ability to schedule segment overrides.
How did you test this code?
Schedule segment overrides, view scheduled changes