Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scheduled segment overrides #4805

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the ability to schedule segment overrides.

image

How did you test this code?

Schedule segment overrides, view scheduled changes

image

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 5, 2024 15:48
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:34pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 5:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 5:34pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 5, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4805 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4805 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4805 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4805 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4805 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4805 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Uffizzi Ephemeral Environment deployment-57965

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4805

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@matthewelwell
Copy link
Contributor

@kyle-ssg I'm a little confused by this one:

Firstly, I don't understand how the following can be true since scheduled updates rely on change requests under the hood, and we don't support change requests for segments in non-versioned environments.

This applies to both versioned and non-versioned environments

Secondly, when I tried to test it, the first thing that happened was that I was just redirected to the billing page directly which confused me. I think it's because scheduled flags aren't available for non-paid plans, but I'm unsure why we're not using the pattern we have elsewhere that shows a banner that it's only available in another plan.

Then, when I tested it in an organisation that is using the enterprise plan, using a non-versioned environment, it just appears to immediately apply the change, I don't see the scheduling modal pop up.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 19, 2024
@kyle-ssg
Copy link
Member Author

kyle-ssg commented Nov 19, 2024

Firstly, I don't understand how the following can be true since scheduled updates rely on change requests under the hood, and we don't support change requests for segments in non-versioned environments.

Ah yep correct, for some reason I thought this worked for both.

Secondly, when I tried to test it, the first thing that happened was that I was just redirected to the billing page directly which confused me.

I've updated the UI to be as such, I don't think we'd want to show a banner here, a simple lock badge should be fine
image

Then, when I tested it in an organisation that is using the enterprise plan, using a non-versioned environment, it just appears to immediately apply the change, I don't see the scheduling modal pop up.

I believe this was due to being tested on a non-versioned project which as you said doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow scheduling changes to segment overrides without change requests enabled
2 participants