Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project/realtime): only allow enterprise to enable realtime #4843

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 19, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Only allow enterprise to toggle real-time updates

How did you test this code?

Covered by unit tests

@gagantrivedi gagantrivedi requested a review from a team as a code owner November 19, 2024 09:16
@gagantrivedi gagantrivedi requested review from zachaysan and removed request for a team November 19, 2024 09:16
@github-actions github-actions bot added the api Issue related to the REST API label Nov 19, 2024
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 19, 2024 9:16am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 19, 2024 9:16am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 19, 2024 9:16am

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4843 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4843 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4843 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4843 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4843 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4843 Finished ✅ Results

@github-actions github-actions bot added the fix label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Uffizzi Preview deployment-58354 was deleted.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (e6f1bac) to head (3d718e7).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4843      +/-   ##
==========================================
+ Coverage   97.33%   97.35%   +0.02%     
==========================================
  Files        1180     1182       +2     
  Lines       41223    41287      +64     
==========================================
+ Hits        40123    40194      +71     
+ Misses       1100     1093       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gagantrivedi gagantrivedi merged commit 9b21af7 into main Nov 19, 2024
34 checks passed
@gagantrivedi gagantrivedi deleted the fix/enable-realtime branch November 19, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants