Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few natives for working with CEconItemView objects. #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NotnHeavy
Copy link

This probably seems like a strange suggestion but should this become mainstream, it should allow me to incorporate some changes in a weapon manager plugin that I am currently in the midst of working on without having to introduce my own natives.

@NotnHeavy
Copy link
Author

The reason I came up with these natives more specifically is so that I can work on patching specific attributes of a specific CEconItemView object before TF2 actually assigns the weapon to a player in CTFPlayer::ManageRegularWeapons(). I don't really want to rewrite functions like CTFPlayer::ItemIsAllowed() completely hence this method.

@FlaminSarge
Copy link
Owner

The reason I came up with these natives more specifically is so that I can work on patching specific attributes of a specific CEconItemView object before TF2 actually assigns the weapon to a player in CTFPlayer::ManageRegularWeapons(). I don't really want to rewrite functions like CTFPlayer::ItemIsAllowed() completely hence this method.

That makes sense, but I thought TF2Items provided a forward to perform that kind of modification already?

@nosoop
Copy link
Collaborator

nosoop commented Jul 4, 2024

That makes sense, but I thought TF2Items provided a forward to perform that kind of modification already?

Upstream TF2Items doesn't do so in a way that works with the weapon pickup mechanic introduced in the Gun Mettle Update.

I'll defer to Sarge on whether or not to pull this in, but I feel like the root problem could be better solved some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants