Add RemoveDirOrFile grpc method #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfectmak
reviewed
Nov 24, 2020
core/space/services/services_fs.go
Outdated
| @@ -703,3 +703,24 @@ func (s *Space) addFile(ctx context.Context, sourcePath string, targetPath strin | |||
| Bytes: fileSize, | |||
| }, err | |||
| } | |||
|
|
|||
| // Removes a file or directory from a bucket | |||
| // Note: If removing a file a user has been shared, it should remove themselves as a member instead of removing the actual file. | |||
There was a problem hiding this comment.
it should remove themselves as a member instead of removing the actual file.
@dmerrill6 Are you still going to work on this? I don't think b.DeleteDirOrFile() does this
There was a problem hiding this comment.
Oh it was badly explained. I meant there should be another method to do that call.
I'll update that comment
perfectmak
approved these changes
Nov 24, 2020
maurycy
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch20270]