Add NSURL init method #5
Conversation
Also, update unit tests and playground.
Calling code can optionally specify the line ending. If they don't specify the line ending then it will be sniffed automatically. By passing the correct line ending to the streamReader() no line ending characters are included in the lines returned from the streamReader. Note that any files with mixed line endings will result in undefined behavior. But it was always like that.
If the correct lineEnding is set for the streamReader no line ending characters will be returned as part of lines. So there's no need to check for them in the line contents.
|
Thanks, looks good at first glance, will have a final look soon and merge. 👍 |
Add .DS_Store to .gitignore
Feature/fix line ending
|
I just had a look into this one, too. And although it looks good I can't merge it as it has conflicts with one of your other MRs that I merged. Could you rebase this MR so I can merge? |
Also, update unit tests and playground.
Also, fix failing tests.
|
I think it's ready now. I think you can close issues 1, 3, 4. I have more improvements for performance and perhaps memory usage. I wanted to wait until these PRs were accepted. Do you have a good way to test memory usage? |
|
Thanks. True, I was gonna check and close those issues right before I release a new version, but I plan to do this soon anyway so gonna close them in a minute. ;) As for automatic testing of the memory usage, I think this is still a missing feature which Xcode should provide. Maybe we get this with Xcode 9 or 10? At least I don't know a way of testing this in a good way automatically, I think we have to stick with improving the memory leaking parts manually and making sure to comment the affected parts in code well so no-one changes them back to memory-leaking code. |
|
@phoney I just gave you write permissions on this project so you can work directly within it using work/ branches. You should also be able to accept merge requests and close issues if appropriate. Please make sure not to merge anything that doesn't comply with the contribution guidelines. Also please don't merge your own changes, even if all tests pass – it is always good to wait until somebody has reviewed your changes. Thanks again for helping improve this project! 👍 |
This pull request adds a simple init method that takes a file NSURL to the csv file.
Unit tests and playground were updated.