Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: helm deployment crashes when no inline values are passed to the workflow #30

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

ppawlowski
Copy link
Collaborator

Description

This PR fixes a problem with helm chart installation within deploy_helm_chart reusable workflow when no inline helm chart values (ones used in helm's --set flag) are passed to the workflow.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit 6f324a9 into main Dec 15, 2023
@hardillb hardillb deleted the fix-helm-empty-values branch December 15, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants