Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Exclude advanced Helm chart validation on release #377

Merged
merged 2 commits into from
May 7, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds a conditional to the helm chart lint pipeline which skips advanced helm chart validation on the release. This change fixes the chicken-egg problem which appears during the release process when container images and Helm chart versions are updated within the same pull request (example).

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb May 6, 2024 20:13
@hardillb hardillb merged commit d3f44ba into main May 7, 2024
6 checks passed
@hardillb hardillb deleted the fix-simple-lint-on-helm-release branch May 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants