Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: revert "ci: Fix CHANGELOG.md path in .releaserc (#385)" #389

Merged
merged 4 commits into from
May 10, 2024
Merged

ci: revert "ci: Fix CHANGELOG.md path in .releaserc (#385)" #389

merged 4 commits into from
May 10, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request reverts #385 .
As a result of above change

  • CHANGELOG.md file was not part of the released Helm chart package
  • changelog was not generated properly for the Github Release

Related Issue(s)

#346

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb May 9, 2024 10:49
@hardillb hardillb merged commit 372c6fc into main May 10, 2024
2 checks passed
@hardillb hardillb deleted the ci-revert-changelog-setting branch May 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb