Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for command history #13

Closed
mvysny opened this issue Oct 12, 2021 · 1 comment · Fixed by #22
Closed

Support for command history #13

mvysny opened this issue Oct 12, 2021 · 1 comment · Fixed by #22
Assignees
@javier-godoy
Labels
enhancement New feature or request

Comments

@mvysny
Copy link
Contributor

mvysny commented Oct 12, 2021 •
edited
Loading

Hi! Pressing the up arrow could look up the last command from the history (or the last line returned via the LineEvent and could auto-fill the command/line for you into the console. Then, by pressing ENTER, the same line would be sent in the LineEvent.

There is no need for history matching (e.g. pressing pg_up/pg_down would only find commands starting with already written input).
@mvysny mvysny changed the title Support for history Support for command history Oct 12, 2021
@javier-godoy javier-godoy self-assigned this Oct 12, 2021
@javier-godoy javier-godoy added the enhancement New feature or request label Oct 12, 2021
javier-godoy added a commit that referenced this issue Oct 18, 2021
@javier-godoy
feat: add support for command history
78c1f32 
Close #13
@javier-godoy javier-godoy mentioned this issue Oct 18, 2021
Merged
@javier-godoy
Copy link
Member

Support for pgUp and pgDown will be included in this feature.

@javier-godoy javier-godoy mentioned this issue Oct 19, 2021
Open
javier-godoy added a commit that referenced this issue Oct 20, 2021
@javier-godoy
feat: add support for command history
fcb408e 
Close #13
mlopezFC pushed a commit that referenced this issue Oct 20, 2021
@javier-godoy @mlopezFC
feat: add support for command history
e278fb4 
Close #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javier-godoy javier-godoy

Labels
enhancement New feature or request
Projects
Flowing Code Addons
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for command history FlowingCode/XTermConsoleAddon
2 participants
@mvysny @javier-godoy