Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "as" casing #3216

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Correct "as" casing #3216

merged 4 commits into from
Sep 19, 2024

Conversation

dillfrescott
Copy link
Contributor

This was driving me crazy when building Flowise as it would give a warning that the casing was not consistent.

@dillfrescott
Copy link
Contributor Author

dillfrescott commented Sep 18, 2024

Also removed "version" from docker compose because that is deprecated. Any modern version of docker will also warn about version being deprecated.

@HenryHengZJ
Copy link
Contributor

Also removed "version" from docker compose because that is deprecated. Any modern version of docker will also warn about version being deprecated.

if others are using the old docker engine, do they still need it?

@dillfrescott
Copy link
Contributor Author

It was removed over a year ago and deprecated. Older docker engine versions are no longer recommended to be used due to security issues and lack of updates.

I suppose if someone's docker version is over a year old it will prompt them to add the version line back. But this seems like an edge case as docker auto updates with system packages.

@dillfrescott
Copy link
Contributor Author

This PR is rather simple, so if you want to just change the AS casing and deny this request that's no big deal.

Maybe we can wait a while before removing the version line, but do know it causes warnings with any modern version of docker.

@HenryHengZJ
Copy link
Contributor

HenryHengZJ commented Sep 19, 2024

cool, for now i will just change the casing first since its just a warning, not blocking it or giving any error

@dillfrescott
Copy link
Contributor Author

Sounds good to me!

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@HenryHengZJ HenryHengZJ merged commit 5742082 into FlowiseAI:main Sep 19, 2024
2 checks passed
0xi4o pushed a commit that referenced this pull request Sep 30, 2024
* Correct "as" casing

* Remove "version" line from docker compose file

* Update docker-compose.yml

---------

Co-authored-by: Henry Heng <[email protected]>
HenryHengZJ added a commit that referenced this pull request Oct 4, 2024
* Add migrations - add follow up prompts column to chatflow and chat message

* Add configuration tab for follow-up prompts

* Add follow up prompts functionality

* Pin zod version in components - this was causing a type error with structured outputs

* Generate follow up prompts if enabled and return it in stream, response, and save to database

* Show follow up prompts after getting response

* Add google gen ai for generating follow up prompts and fix issues

* Add config for google gen ai and update model options

* Update follow-up prompts ui and styles

* Release/2.1.0 (#3204)

[email protected] release

* Chore/update flowise embed version to 2.0.0 (#3205)

* update flowise-embed version on lock file

* add agent messages to share chatbot

* Update pnpm-lock.yaml

* update flowise-embed version

* update flowise-embed to 1.3.9

* update embed version to 2.0

* Bugfix/CodeInterpreter E2B Credential (#3206)

* Base changes for ServerSide Events (instead of socket.io)

* lint fixes

* adding of interface and separate methods for streaming events

* lint

* first draft, handles both internal and external prediction end points.

* lint fixes

* additional internal end point for streaming and associated changes

* return streamresponse as true to build agent flow

* 1) JSON formatting for internal events
2) other fixes

* 1) convert internal event to metadata to maintain consistency with external response

* fix action and metadata streaming

* fix for error when agent flow is aborted

* prevent subflows from streaming and other code cleanup

* prevent streaming from enclosed tools

* add fix for preventing chaintool streaming

* update lock file

* add open when hidden to sse

* Streaming errors

* Streaming errors

* add fix for showing error message

* add code interpreter

* add artifacts to view message dialog

* Update pnpm-lock.yaml

* uncomment e2b credential

---------

Co-authored-by: Vinod Paidimarry <[email protected]>

* Release/2.1.0 (#3207)

* [email protected] release

* update [email protected]

* Bugfix/Add artifacts migration script to other database types (#3210)

add artifacts migration script to other database types

* Release/2.1.1 (#3213)

release @2.1.1

* Bugfix/Add header to allow sse on nginx (#3214)

add header to allow sse on nginx

* Bugfix/remove invalid markdown (#3219)

remove invalid markdown

* Correct "as" casing (#3216)

* Correct "as" casing

* Remove "version" line from docker compose file

* Update docker-compose.yml

---------

Co-authored-by: Henry Heng <[email protected]>

* chore: update unstructured API url and doc reference (#3224)

chore: udpate unstructured API url and doc reference

* Feature/add ability to specify dynamic metadata to jsonlines (#3238)

* add ability to specify dynamic metadata to jsonlines

* fix additional metadata

* Bugfix/Buffer Memory for Anthropic (#3242)

fix buffer memory

* Added env vars to ui and api URL  (#3141)

* feat: add environment vars to split application in different deployments for better scalability

* update: package.json

added start script ui

---------

Co-authored-by: patrick <[email protected]>

* Added 1-click deployment link for Alibaba Cloud.  (#3251)

* Added a link for Alibaba Cloud Deployment

* change service name

---------

Co-authored-by: yehan <[email protected]>

* Chore/Groq Llama3.2 (#3255)

* add gemini flash

* add gemin flash to vertex

* add gemin-1.5-flash-preview to vertex

* add azure gpt 4o

* add claude 3.5 sonnet

* add mistral nemo

* add groq llama3.1

* add gpt4o-mini to azure

* o1 mini

* add groq llama 3.2

* Bugfix/Prevent streaming of chatflow tool and chain tool (#3257)

prevent streaming of chatflow tool and chain tool

* Bugfix/Enable Custom Tool Optional Input Schema (#3258)

* prevent streaming of chatflow tool and chain tool

* enable optional input schema

* Bugfix/Searxng tool not working (#3263)

fix searxng tool not working

* LunaryAI automatic Thread and User tracking (#3233)

* Lunary Thread/User tracking

* Clean console logs

* Clean

* Remove commented lines

* Remove commented line

* feat: enable autofocus to the `new chatflow title` to improve usability (#3260)

This dialog has only one input and it is the primary one, there is no need for an extra click to be able to set the title

* feat: save a new Chatflow when the `ENTER` key is pressed (#3261)

This simple event handler improve the usability of the UI by avoiding having to use the mouse or having to tab twice and then hit enter to save a flow

* feat: save Chatflow title when the `ENTER` key is pressed or discard upon `ESC` is pressed (#3265)

This simple event handler improves the usability of the UI by avoiding having to use the mouse to save or dicard title changes

* feat: enable autofocus to the `edit chatflow title` field to improve UI usability (#3264)

feat: enable autofocus to the `edit chatflow title` field to improve usability

The canvas header has only one input and it is the primary one, there is no need for an extra click to be able to edit the title

* feat: add search keyboard shortcut based on the current platform (#3267)

* feat: highlight valid/invalid connection between nodes (#3266)

Change the inputs background to green/red to hint compatible connections, in adition to the `not-allowed` mouse cursor for incompatible connections

* Bugfix/add fixes for search of view header (#3271)

add fixes for search of view header

* fix: warning when passing a boolean to border property of a Card (#3275)

By default MainCard wrappers like NodeCardWrapper and CardWrapper add a a solid border of 1px, but if the `MainCard.border` prop is used (`false`) the border prop was wrongly set to a boolean instead of string

* feat: add shortcut text hint to the search field (#3269)

* feat: add shortcut text hint to the search field

* fix: search box width to fit the shortcut hint text

* fix: error when not running on Mac due to an undefined `os` variable

* fix: warning when a non-boolean values was used to set `checked` prop of a SwitchInput component (#3276)

fix: warning when a non-boolean values was used to set`checked` prop of SwitchInput component

The problem was that in the useEffect hook the plain value was used without validation like in useState

* Bugfix/Throw error to prevent SSE from retrying (#3281)

throw error to prevent SSE from retrying

* Pin zod version in components - this was causing a type error with structured outputs

* Fix conflicts in pnpm lock

* fix ui changes for follow up prompts

* Fix button disable state in follow-up prompts configuration

* Fix follow-up prompts not showing up for agent flows

* Show follow up prompts if last message is apiMessage and follow up prompts are available

---------

Co-authored-by: Henry Heng <[email protected]>
Co-authored-by: Vinod Paidimarry <[email protected]>
Co-authored-by: Cross <[email protected]>
Co-authored-by: cragwolfe <[email protected]>
Co-authored-by: patrickreinan <[email protected]>
Co-authored-by: patrick <[email protected]>
Co-authored-by: yehan <[email protected]>
Co-authored-by: yehan <[email protected]>
Co-authored-by: Vincelwt <[email protected]>
Co-authored-by: Humberto Rodríguez A. <[email protected]>
Co-authored-by: Henry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants