Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'cdr_type' macro not working in FlowETL QA checks #3479

Closed
jc-harrison opened this issue Jan 13, 2021 · 3 comments · Fixed by #3481
Closed

'cdr_type' macro not working in FlowETL QA checks #3479

jc-harrison opened this issue Jan 13, 2021 · 3 comments · Fixed by #3481
Labels
bug Something isn't working FlowETL

Comments

@jc-harrison
Copy link
Member

The if/else block in the 'count_duplicates' and 'count_duplicated' QA check templates is always rendered as an empty string, regardless of the value of the cdr_type argument to create_dag.

@jc-harrison jc-harrison added bug Something isn't working FlowETL labels Jan 13, 2021
@greenape
Copy link
Member

Should be params.cdr_type, I think?

@greenape
Copy link
Member

Will also apply to count_msisdns.

@greenape
Copy link
Member

I think obvious thing to do would be to add cdr_type here:

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowETL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants