Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache cleanup fails if it hits a custom class #4008

Closed
greenape opened this issue May 6, 2021 · 1 comment · Fixed by #4493
Closed

Cache cleanup fails if it hits a custom class #4008

greenape opened this issue May 6, 2021 · 1 comment · Fixed by #4493
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented May 6, 2021

If the cache cleanup op hits a new query subclass, it will fail because it can't be unpickled.
@greenape greenape added bug Something isn't working FlowMachine Issues related to FlowMachine labels May 6, 2021
@greenape
Copy link
Member Author

greenape commented May 6, 2021

Solution is probably to switch to using dill for the pickling?

@greenape greenape added the P-Now label Sep 23, 2021
greenape added a commit that referenced this issue Nov 1, 2021
@greenape
Switch to dill for query pickling #4008
3f56d00
greenape added a commit that referenced this issue Nov 1, 2021
@greenape
Revert "Switch to dill for query pickling #4008"
4ee47a7 
This reverts commit 3f56d00.
greenape added a commit that referenced this issue Nov 8, 2021
@greenape
Add changelog for fix for #4008
2376f2b
@greenape greenape mentioned this issue Nov 8, 2021
Merged
8 tasks
greenape added a commit that referenced this issue Nov 26, 2021
@greenape
Add changelog for fix for #4008
279a840
greenape added a commit that referenced this issue Nov 30, 2021
@greenape
Add changelog for fix for #4008
da5053d
greenape added a commit that referenced this issue Dec 15, 2021
@greenape
Add changelog for fix for #4008
8560dbb
@mergify mergify bot closed this as completed in #4493 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cannot uncache novel objs Flowminder/FlowKit
1 participant
@greenape