Rename .md5 .query_id #1289
Merged
Rename .md5 .query_id #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxalbert
reviewed
Sep 19, 2019
| @@ -216,7 +218,7 @@ def touch_cache(connection: "Connection", query_id: str) -> float: | |||
| ---------- | |||
| connection : Connection | |||
| query_id : str | |||
| md5 id of the query to touch | |||
| query_id id of the query to touch | |||
There was a problem hiding this comment.
The duplicate id should be removed in this docstring (and the others below).
maxalbert
reviewed
Sep 19, 2019
| @@ -602,7 +604,7 @@ def get_compute_time(connection: "Connection", query_id: str) -> float: | |||
| ---------- | |||
| connection : "Connection" | |||
| query_id : str | |||
| md5 identifier of the query | |||
| query_id identifier of the query | |||
There was a problem hiding this comment.
Maybe similar here? "query_id identifier" sounds less of a duplication than "query_id id", but maybe just use "identifier"?
maxalbert
reviewed
Sep 19, 2019
| @@ -90,7 +90,7 @@ class QueryStateMachine: | |||
| redis_client : StrictRedis | |||
| Client for redis | |||
| query_id : str | |||
| md5 query identifier | |||
| query_id query identifier | |||
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 94.12% 94.07% -0.05%
==========================================
Files 155 155
Lines 7484 7483 -1
Branches 697 697
==========================================
- Hits 7044 7040 -4
- Misses 333 334 +1
- Partials 107 109 +2
Continue to review full report at Codecov.
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
maxalbert
approved these changes
Sep 19, 2019
Co-Authored-By: maxalbert <[email protected]>
Co-Authored-By: maxalbert <[email protected]>
greenape
force-pushed
the
md5-to-query_id
branch
from
b7a62ea
to
14b9161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1288
I have:
Description
Renames query's
.md5attribute to.query_id.