Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable histograms via flowapi #2059

Merged
merged 8 commits into from
Apr 8, 2020
Merged

Enable histograms via flowapi #2059

merged 8 commits into from
Apr 8, 2020

Conversation

greenape
Copy link
Member

@greenape greenape commented Mar 4, 2020

Closes #1076

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Taking advantage of the recent change to api permissions.. This enables histograms through flowapi.

@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine FlowAPI Issues related to the FlowKit API ready-to-merge Label indicating a PR is OK to automerge labels Mar 4, 2020
@cypress
Copy link

cypress bot commented Mar 10, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 0e6ae3d
Started Apr 8, 2020 4:08 PM
Ended Apr 8, 2020 4:10 PM
Duration 01:58 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #2059 into master will decrease coverage by 0.09%.
The diff coverage is 83.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   95.40%   95.31%   -0.10%     
==========================================
  Files         209      210       +1     
  Lines        8552     8618      +66     
  Branches      809      814       +5     
==========================================
+ Hits         8159     8214      +55     
- Misses        280      287       +7     
- Partials      113      117       +4     
Flag Coverage Δ
#autoflow_unit_tests 92.91% <ø> (ø)
#flowapi_unit_tests 82.10% <ø> (ø)
#flowauth_unit_tests 94.74% <ø> (ø)
#flowclient_unit_tests 75.21% <33.33%> (-1.59%) ⬇️
#flowetl_unit_tests 100.00% <ø> (ø)
#flowkit_jwt_generator_unit_tests 100.00% <ø> (ø)
#flowmachine_unit_tests 91.12% <73.21%> (-0.17%) ⬇️
#integration_tests 71.41% <83.82%> (+0.29%) ⬆️
Impacted Files Coverage Δ
flowclient/flowclient/aggregates.py 94.36% <66.66%> (-5.64%) ⬇️
...machine/core/server/query_schemas/custom_fields.py 74.50% <66.66%> (-2.24%) ⬇️
...e/core/server/query_schemas/histogram_aggregate.py 91.30% <91.30%> (ø)
...ine/core/server/query_schemas/flowmachine_query.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c66e0e...0e6ae3d. Read the comment docs.

@greenape greenape force-pushed the histogram-api branch 4 times, most recently from e34c383 to 46321ff Compare March 19, 2020 13:58
@greenape greenape force-pushed the histogram-api branch 4 times, most recently from cc9229d to 9e124d3 Compare April 7, 2020 20:45
@greenape greenape merged commit 13e1b73 into master Apr 8, 2020
@greenape greenape deleted the histogram-api branch April 8, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowAPI Issues related to the FlowKit API FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose histogram aggregation via API
1 participant