COVID-19 API endpoints #2253

greenape · 2020-04-02T13:54:24Z

I have:

Formatted any Python files with black
Brought the branch up to date with master
Added any relevant Github labels
Added tests for any new additions
Added or updated any relevant documentation
Added an Architectural Decision Record (ADR), if appropriate
Added an MPLv2 License Header if appropriate
Updated the Changelog

Description

Adds api endpoints for indicators in #2244

cypress · 2020-04-02T14:05:56Z

Test summary

43 • 0 • 0 • 0

Run details


Project	FlowAuth
Status	Passed
Commit	`5d0a623`
Started	Apr 21, 2020 11:56 AM
Ended	Apr 21, 2020 11:58 AM
Duration	02:07 💡
OS	Linux Debian - 8.11
Browser	Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

codecov · 2020-04-02T14:17:54Z

Codecov Report

Merging #2253 into master will decrease coverage by 0.22%.
The diff coverage is 93.72%.

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
- Coverage   95.35%   95.13%   -0.23%     
==========================================
  Files         226      235       +9     
  Lines        8866     9019     +153     
  Branches      832      833       +1     
==========================================
+ Hits         8454     8580     +126     
- Misses        293      320      +27     
  Partials      119      119

Flag	Coverage Δ
#autoflow_unit_tests	`92.91% <ø> (ø)`
#flowapi_unit_tests	`82.10% <ø> (ø)`
#flowauth_unit_tests	`94.75% <75.00%> (+0.01%)`	⬆️
#flowclient_unit_tests	`75.21% <ø> (ø)`
#flowetl_unit_tests	`100.00% <ø> (ø)`
#flowkit_jwt_generator_unit_tests	`100.00% <ø> (ø)`
#flowmachine_unit_tests	`91.44% <92.53%> (+0.09%)`	⬆️
#integration_tests	`71.14% <93.43%> (+1.27%)`	⬆️

Impacted Files	Coverage Δ
...features/location/redacted_unique_vistor_counts.py	`90.47% <ø> (ø)`
flowauth/backend/flowauth/servers.py	`97.61% <75.00%> (+0.05%)`	⬆️
...hine/core/server/query_schemas/unique_locations.py	`75.00% <75.00%> (ø)`
...erver/query_schemas/consecutive_trips_od_matrix.py	`80.00% <80.00%> (ø)`
...chine/core/server/query_schemas/trips_od_matrix.py	`80.00% <80.00%> (ø)`
...core/server/query_schemas/unique_visitor_counts.py	`84.21% <84.21%> (ø)`
...ery_schemas/active_at_reference_location_counts.py	`85.71% <85.71%> (ø)`
...y_schemas/unmoving_at_reference_location_counts.py	`85.71% <85.71%> (ø)`
...chine/core/server/query_schemas/unmoving_counts.py	`88.88% <88.88%> (ø)`
.../server/query_schemas/aggregate_network_objects.py	`100.00% <100.00%> (ø)`
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b21c4...5d0a623. Read the comment docs.

codecov · 2020-04-02T14:17:58Z

Codecov Report

Merging #2253 into master will decrease coverage by 0.18%.
The diff coverage is 87.00%.

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
- Coverage   95.40%   95.22%   -0.19%     
==========================================
  Files         209      219      +10     
  Lines        8538     8727     +189     
  Branches      807      810       +3     
==========================================
+ Hits         8146     8310     +164     
- Misses        280      302      +22     
- Partials      112      115       +3

Flag	Coverage Δ
#autoflow_unit_tests	`92.91% <ø> (ø)`
#flowapi_unit_tests	`82.10% <ø> (ø)`
#flowauth_unit_tests	`94.75% <75.00%> (+0.01%)`	⬆️
#flowclient_unit_tests	`77.67% <ø> (ø)`
#flowetl_unit_tests	`100.00% <ø> (ø)`
#flowkit_jwt_generator_unit_tests	`100.00% <ø> (ø)`
#flowmachine_unit_tests	`91.15% <87.24%> (-0.15%)`	⬇️
#integration_tests	`71.02% <69.89%> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
flowmachine/flowmachine/features/location/flows.py	`94.59% <ø> (ø)`
...hine/features/location/redacted_location_metric.py	`100.00% <ø> (ø)`
...hine/core/server/query_schemas/unique_locations.py	`72.00% <72.00%> (ø)`
flowauth/backend/flowauth/servers.py	`97.61% <75.00%> (+0.05%)`	⬆️
...core/server/query_schemas/unique_visitor_counts.py	`78.94% <78.94%> (ø)`
...rver/query_schemas/active_at_reference_location.py	`80.00% <80.00%> (ø)`
...ery_schemas/active_at_reference_location_counts.py	`82.35% <82.35%> (ø)`
...machine/features/location/unique_visitor_counts.py	`90.00% <90.00%> (ø)`
...features/location/redacted_unique_vistor_counts.py	`90.47% <90.47%> (ø)`
...eatures/subscriber/active_at_reference_location.py	`90.47% <90.47%> (ø)`
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbb6f1...8e49c53. Read the comment docs.

jc-harrison

A couple of small comments, but this looks good.

jc-harrison · 2020-04-17T11:31:07Z

flowmachine/flowmachine/core/server/query_schemas/consecutive_trips_od_matrix.py

+        *,
+        aggregation_unit,
+        subscriber_subset=None,
+        sampling=None


Is this supposed to have a 'sampling' parameter? It's not used anywhere.

(same for TripsODMatrixExposed)

jc-harrison · 2020-04-17T12:20:41Z

flowmachine/flowmachine/core/server/query_schemas/unique_visitor_counts.py

+        -------
+        Query
+        """
+        # Note we're not using the redacted version here, because the two composing queries are redacted


Reflecting on this, I think RedactedUniqueVisitorCounts should redact after subtracting active residents from unique subscribers, because otherwise a region with 17 unique subscribers, 16 of whom are active residents, will return 1 unique visitor.

On the other hand, one could separately calculate unique_subscriber_counts and active_at_reference_location_counts and do the subtraction outside of FlowKit, so redacting UniqueVisitorCounts wouldn't help. I'm not sure how to get around that.

jc-harrison

(My previous comment was meant to be an approval)

… regional pair connections

…pling from top level queries

Co-Authored-By: James Harrison <[email protected]>

greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine FlowAPI Issues related to the FlowKit API labels Apr 2, 2020

greenape force-pushed the indicator-api branch from 5e2e6bf to 8e49c53 Compare April 2, 2020 13:55

greenape force-pushed the indicator-api branch 7 times, most recently from 5bbd60a to ae0451e Compare April 8, 2020 19:46

greenape mentioned this pull request Apr 13, 2020

Add flowclient functions for new Covid-19 aggregates #2333

Closed

greenape force-pushed the indicator-api branch 10 times, most recently from 0d726b0 to d1e5cff Compare April 15, 2020 09:31

jc-harrison reviewed Apr 17, 2020

View reviewed changes

jc-harrison approved these changes Apr 20, 2020

View reviewed changes

greenape added 3 commits April 20, 2020 22:00

Fix #2304

334a306

Update changeloh for 1.6.1

e582ef6

Add unique locations schema, and add it to flows to allow calculating…

0d013e5

… regional pair connections

greenape added 15 commits April 20, 2020 22:00

Add refence location activity schemas

9148ec7

Add unique visitor counts schema

1ba496c

Nest schemas

f8e207e

Update approval tests

7857341

Faster caps update

41c9707

Update CHANGELOG.md

1020ec8

Add consecutive trips to API

b1eb68b

Add unmoving counts to api

9d9f72f

Add unmoving at reference location counts to api, and remove some sam…

69a9ee2

…pling from top level queries

Update approval tests

be81f0d

Update consecutive trips name

f23ef6c

Fix unique locations because it isn't always wrapped in a oneof

a795517

Add trips od

bb9cc78

Remove a level of active at reference location counts

c3e09c3

Remove query kind when loading if present

f669eaa

greenape force-pushed the indicator-api branch from d1e5cff to f669eaa Compare April 20, 2020 21:03

greenape and others added 4 commits April 21, 2020 09:33

Remove unused param

2904eb5

Relock

872fe25

Relock again

28dd76c

Standard redaction for unique visitor counts

5d0a623

Co-Authored-By: James Harrison <[email protected]>

greenape added the ready-to-merge Label indicating a PR is OK to automerge label Apr 21, 2020

mergify bot merged commit 305448b into master Apr 21, 2020

mergify bot deleted the indicator-api branch April 21, 2020 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COVID-19 API endpoints #2253

COVID-19 API endpoints #2253

greenape commented Apr 2, 2020

cypress bot commented Apr 2, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020

jc-harrison left a comment

jc-harrison Apr 17, 2020

jc-harrison Apr 17, 2020

jc-harrison Apr 17, 2020

jc-harrison left a comment

COVID-19 API endpoints #2253

COVID-19 API endpoints #2253

Conversation

greenape commented Apr 2, 2020

I have:

Description

cypress bot commented Apr 2, 2020 • edited Loading

Test summary

Run details

codecov bot commented Apr 2, 2020 • edited Loading

Codecov Report

codecov bot commented Apr 2, 2020

Codecov Report

jc-harrison left a comment

Choose a reason for hiding this comment

jc-harrison Apr 17, 2020

Choose a reason for hiding this comment

jc-harrison Apr 17, 2020

Choose a reason for hiding this comment

jc-harrison Apr 17, 2020

Choose a reason for hiding this comment

jc-harrison left a comment

Choose a reason for hiding this comment

cypress bot commented Apr 2, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading