Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support validity window for Flowauth 2factor #3204

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Support validity window for Flowauth 2factor #3204

merged 2 commits into from
Nov 3, 2020

Conversation

greenape
Copy link
Member

@greenape greenape commented Nov 2, 2020

Closes #3203

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Allows setting the validity window for two factor code verification in Flowauth using TWO_FACTOR_VALID_WINDOW env var.

@greenape greenape added enhancement New feature or request FlowAuth Issues related to FlowAuth security labels Nov 2, 2020
@cypress
Copy link

cypress bot commented Nov 2, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 3dc773f
Started Nov 3, 2020 11:46 AM
Ended Nov 3, 2020 11:48 AM
Duration 02:04 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3204 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3204   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files         251      251           
  Lines       10042    10042           
  Branches      858      858           
=======================================
  Hits         9391     9391           
  Misses        523      523           
  Partials      128      128           
Flag Coverage Δ
autoflow_unit_tests 92.99% <ø> (ø)
flowapi_unit_tests 72.84% <ø> (ø)
flowauth_unit_tests 78.39% <100.00%> (ø)
flowclient_unit_tests 80.25% <ø> (ø)
flowetl_unit_tests 95.38% <ø> (ø)
flowkit_jwt_generator_unit_tests 95.10% <ø> (ø)
flowmachine_unit_tests 90.79% <ø> (ø)
integration_tests 66.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flowauth/backend/flowauth/config.py 90.24% <ø> (ø)
flowauth/backend/flowauth/models.py 92.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156993d...3dc773f. Read the comment docs.

@greenape greenape merged commit 16d34e8 into master Nov 3, 2020
@greenape greenape deleted the clock-skew branch November 3, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowAuth Issues related to FlowAuth security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring valid window for Flowauth 2factor
1 participant