-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for COUNT instead of just first row in data_present_sensor #5897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be more efficient to do "select exists (select * from {{staging_table}} limit 1)"
Approved - add a changelog before sticking ready to merge label on |
Codecov Report
@@ Coverage Diff @@
## master #5897 +/- ##
===========================================
- Coverage 93.23% 78.39% -14.85%
===========================================
Files 277 277
Lines 10828 10828
Branches 895 895
===========================================
- Hits 10096 8489 -1607
- Misses 602 2095 +1493
- Partials 130 244 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closes #5090
I have:
Description
Instead of
SELECT
ing the first row instaging_table
indata_present_sensor
, this PR uses COUNT to check for data presence. This would still fail if no records are present (COUNT (*) would return 0 in the first cell), but would work if there's any data present in the first 100 records (arbitarily selected)