Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode for AggregateNetworkObjects #663

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Fix mode for AggregateNetworkObjects #663

merged 4 commits into from
Apr 24, 2019

Conversation

greenape
Copy link
Member

Closes #651

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Fixes calculating a modal average with aggregate network objects by applying the required special case, and changes the column name to value rather than having it vary with the stat you asked for.

@greenape greenape added bug Something isn't working FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge labels Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #663 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   93.49%   93.49%   +<.01%     
==========================================
  Files         125      125              
  Lines        6271     6274       +3     
  Branches      665      666       +1     
==========================================
+ Hits         5863     5866       +3     
  Misses        284      284              
  Partials      124      124
Impacted Files Coverage Δ
...wmachine/features/network/total_network_objects.py 97.22% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a100ea8...a138f9d. Read the comment docs.

@mergify mergify bot merged commit 077f89c into master Apr 24, 2019
@mergify mergify bot deleted the fix-tno-mode branch April 24, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AggregateNetworkObjects "mode" statistic isn't working
2 participants