Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py force rack_u_position to string value. #195

Merged

Conversation

ekrichbaum
Copy link
Contributor

Describe your changes

wrap value for rack_u_position to str().

Issue ticket number and link

https://github.com/FlxPeters/netbox-plugin-prometheus-sd/issues/194

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@jsenecal
Copy link
Contributor

@FlxPeters Can this have some traction please? This breaks our current deployment and we would appreciate not running a git package in production.

@dan3805
Copy link

dan3805 commented Sep 16, 2024

same here , This issue is causing significant problems with our current deployment, Could we get some movement on this?

@FlxPeters FlxPeters force-pushed the Device-unmarshall-error-fix-for-rack-unit branch from fd3c5ba to 2eb8964 Compare September 17, 2024 07:08
@FlxPeters
Copy link
Owner

Github actions seems to have an issue with docker compose. I fixed the test so the fixtures are a decimal like in the netbox model. Tests are success locally.

I also fixed the commit message to comply with conventional commits

@FlxPeters FlxPeters merged commit 88b4fd8 into FlxPeters:main Sep 17, 2024
0 of 7 checks passed
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jsenecal
Copy link
Contributor

Many thanks for the release.

FYI, https://github.com/FlxPeters/netbox-plugin-prometheus-sd/blob/main/netbox_prometheus_sd/__init__.py#L13C5-L13C20 has not been changed to reflect the new version.

@FlxPeters
Copy link
Owner

Thanks for the hint. I introduced an automated release some time ago and this needs to be updated as well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants