forked from juicycleff/flutter-unity-view-widget
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android textureview player #1
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c623cf0
chore(docs): updated README.md
juicycleff aaa4309
chore(flutter): migrated to null-safety
juicycleff 2245485
chore(flutter): migrated to null-safety
juicycleff aee1c12
chore(flutter): migrated to null-safety
juicycleff 91fdb73
Merge branch 'master' into null_safe
juicycleff 7c0fcfc
chore: 4.0.3-null-safe new version release
juicycleff 562f38a
release(4.1.0): fix for ios bitcode null-safe
juicycleff aaaa147
chore: updated README.md
juicycleff 8f85f00
Merge branch 'master' into null_safe
juicycleff 14e3aeb
Merge pull request #371 from juicycleff/null_safe
juicycleff 7c9f9bc
chore: made 4.2.0 null safe release
juicycleff b166353
fix: fixed bad null safety implementation
juicycleff c0e6dea
fix: fixed bad null safety implementation
juicycleff 693a7fd
Add texture view workaround for android
ivanarellano 6727823
Merge branch 'master' into android-textureview-player
ivanarellano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
analyzer: | ||
enable-experiment: | ||
- non-nullable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand any of this lol. Which is fine. Just one question out of curiosity. This if seems to be checking if the version number is below zero? Wondering what this is checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build.VERSION_CODES.O
at first glance does look like a 0. I wish they didn't truncate "Oreo" to "O". At runtime this constant int is 26. https://developer.android.com/reference/android/os/Build.VERSION_CODES#OThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding what the code does, the majority of the work is happening within the unity generated library via
unityPlayer!!.addViewToPlayer(view, true)
. The code above that is instantiating aTextureView
from the Android SDK and setting it up so that the unity player view renders to it. The unity player shows our newly madeTextureView
because callingaddViewToPlayer
swaps the internal surface with ourTextureView
.