Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Commit

Permalink
[AIRFLOW-6352] security - ui - add login timeout (apache#6912)
Browse files Browse the repository at this point in the history
  • Loading branch information
tooptoop4 authored and galuszkak committed Mar 5, 2020
1 parent 167918c commit da8f3ff
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
5 changes: 4 additions & 1 deletion airflow/config_templates/default_airflow.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -370,10 +370,13 @@ default_wrap = False
# on webserver startup
update_fab_perms = True

# Minutes of non-activity before logged out from UI
# 0 means never get forcibly logged out
force_log_out_after = 0

[email]
email_backend = airflow.utils.email.send_email_smtp


[smtp]
# If you want airflow to send emails on retries, failure, and you want to use
# the airflow.utils.email.send_email_smtp function, you have to configure an
Expand Down
12 changes: 12 additions & 0 deletions airflow/www/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@
# specific language governing permissions and limitations
# under the License.
#
import datetime
import logging
import socket
from typing import Any, Optional
from urllib.parse import urlparse

import flask
import flask_login
from flask import Flask
from flask_appbuilder import SQLA, AppBuilder
from flask_caching import Cache
Expand Down Expand Up @@ -229,6 +232,15 @@ def jinja_globals(): # pylint: disable=unused-variable

return globals

@app.before_request
def before_request():
_force_log_out_after = conf.getint('webserver', 'FORCE_LOG_OUT_AFTER', fallback=0)
if _force_log_out_after > 0:
flask.session.permanent = True
app.permanent_session_lifetime = datetime.timedelta(minutes=_force_log_out_after)
flask.session.modified = True
flask.g.user = flask_login.current_user

@app.teardown_appcontext
def shutdown_session(exception=None): # pylint: disable=unused-variable
settings.Session.remove()
Expand Down

0 comments on commit da8f3ff

Please sign in to comment.