Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row option #148

Merged
merged 36 commits into from
Jul 1, 2023
Merged

Add row option #148

merged 36 commits into from
Jul 1, 2023

Conversation

GrylledCheez
Copy link
Collaborator

@GrylledCheez GrylledCheez commented Jun 23, 2023

The following functionality is provided

  • option for 1 to 5 rows
  • ctrl+drag to drop into arbitrary grid locations
  • shrinking going up
    • 2 cols
    • 3 cols
    • 4 cols
  • shrinking down
    • 2 cols
    • 3 cols
    • 4 cols
  • moving going up
    • 2 cols
    • 3 cols
    • 4 cols
  • moving down
    • 2 cols
    • 3 cols
    • 4 cols

v12.
Time marches on
Removed redundant math in showPreview function since we already have
the loc and don't need to do extra calculations.
default gap is zero, but can can be increased to 50 in 2px increments
simpler coding for switch cases and allows for the possibility of
code condensing later
* fixes requested by gnome

Changed version checking to be float instead of int so we can deprecate < 3.36 later
Added settings-schema to metadata.json so ExtensionUtils.getSettings can find it
Removed disable function from prefs.js
Made extension.js definitions consistent with prefs.js

resolves #137
Instead of doing silly pixel math with the pointer, check to see
if the metaGrabOp is any of the Meta.GrabOp resize constants.
Fixed manual instalation instructions
removed a single newline that was causing github to go crazy and double create init in prefs.js
each log line will now start with the name of the function followed by a ")"
This will make it easier to grep for relevant logs
Gave instructions on getting wintile logs
@GrylledCheez GrylledCheez changed the base branch from develop to master June 26, 2023 07:02
@GrylledCheez GrylledCheez changed the base branch from master to develop June 26, 2023 07:05
Users can choose between 1 and 5 rows
Holding ctrl during a drag event will show the preview in the grid the mouse is in.
Very useful for grids with more than 2 rows.
@GrylledCheez
Copy link
Collaborator Author

@phavekes and @Fmstrat I'm going to need some extensive testing with this one. It works as I expect, but if it's wildly different, I'll need help getting it where we need it to be.

If it works, merge it to master as well.

@GrylledCheez GrylledCheez marked this pull request as ready for review June 26, 2023 11:27
@GrylledCheez GrylledCheez changed the title [WIP] Add row option Add row option Jun 26, 2023
@GrylledCheez GrylledCheez merged commit 82a7fed into develop Jul 1, 2023
@GrylledCheez GrylledCheez deleted the add_row_option branch July 1, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant