Vertical bigger image issue

[hbabuc]

hi, firstly this plugin is awesome, but we found an issue;

when we select a vertical bigger image on top, there is no issue but;

when we selected vertical bigger image on bottom, there will be a black box in the output image.
I hope i can tell you the issue exactly. In the horizontal bigger images, there is no problem.

Thank you.

[patrickng]

I see this issue as well. I think it's related to #247 and #318. The problem seems to be that when the code

            if (left < 0) {
                startX = Math.abs(left);
                left = 0;
            }
            if (top < 0) {
                startY = Math.abs(top);
                top = 0;
            }
            if (right > self._originalImageWidth) {
                width = self._originalImageWidth - left;
                outWidth = width;
            }
            if (bottom > self._originalImageHeight) {
                height = self._originalImageHeight - top;
                outHeight = height;
            }

is not properly enclosed by a conditional that checks if (!self.options.enforceBoundary) according to the comment on line 982 (// start fixing data to send to draw image for enforceBoundary: false)

That bit of code seems to not be necessary if you did not specify enforceBoundary: false in the options.

If that bit of code was changed to:

        // start fixing data to send to draw image for enforceBoundary: false
        if (!self.options.enforceBoundary) {
            if (left < 0) {
                startX = Math.abs(left);
                left = 0;
            }
            if (top < 0) {
                startY = Math.abs(top);
                top = 0;
            }
            if (right > self._originalImageWidth) {
                width = self._originalImageWidth - left;
                outWidth = width;
            }
            if (bottom > self._originalImageHeight) {
                height = self._originalImageHeight - top;
                outHeight = height;
            }
        }

then it seems to work just fine.

[hbabuc]

ohh thank you, it worked really well. you just saved me a lot of work 👍