Wrap calculations for enforceBoundary: false in a conditional #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! Nice catch. Thanks for helping out. |
|
#293 seems resolved too. |
|
Perfect, thanks guys :) |
|
Seems there is a problem still with enforceBoundary disabled on mobile where if you pinch to zoomout and rotate the image it just returns a blank white box. (The image needs to not be touching any of the edges) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #247 and #325. There was a comment implying the offsets and calculations were only for enforceBoundary: false option - which caused problems for the default option of enforceBoundary: true.
Hope this helps!